Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number added to beginning of commit message #30

Closed
RTSchriner opened this issue Feb 8, 2019 · 4 comments
Closed

Version number added to beginning of commit message #30

RTSchriner opened this issue Feb 8, 2019 · 4 comments

Comments

@RTSchriner
Copy link

The version number is added to the beginning of the commit message instead of the end.

Steps to recreate:

  1. NPM package.json version is v1.7.0-alpha.0
  2. Run bump --preminor --lock --commit 'Upgrading to v'
  3. New commit message is "v1.8.0-alpha.0 Upgrading to v"
@JamesMessinger
Copy link
Member

Weird. I swore it was being appended, but the code doesn't lie. It's definitely being pre-pended:

if (options.commitMessage) {
commitMessage = "v" + newVersion + " " + options.commitMessage;
}

I think the best solution is to go ahead and add the placeholder functionality that we discussed in Issue #29

@RTSchriner
Copy link
Author

No worries, sounds good! 👍

@JamesMessinger
Copy link
Member

I just released version 5.0.0, which resolves this issue.

@RTSchriner
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants