Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to exclude version scripts #40

Merged
merged 15 commits into from
Aug 29, 2020

Conversation

sidtagirisa
Copy link
Contributor

@sidtagirisa sidtagirisa commented Aug 1, 2020

implements a feature to skip specified version scripts from running by default with a new argument called --ignore-scripts which defaults to false

closes: #39

Copy link
Member

@JamesMessinger JamesMessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@setshaft - Thanks for the PR! You did a great job on this, but I'd like to go with a boolean --ignore-scripts flag like NPM has, rather than a --skip-version-scripts array. The array will cause conflicts/confusion with the files variadic argument. We could take steps to mitigate that problem, but I don't think it's worthwhile, given that the primary use-case will be to skip all NPM scripts, so a simple boolean flag works.

@sidtagirisa
Copy link
Contributor Author

@JamesMessinger Sure, I will make changes when I have some free time and update you on this :)

@sidtagirisa
Copy link
Contributor Author

@JamesMessinger I have made the requested changes please take a look now 😊.

@sidtagirisa
Copy link
Contributor Author

Hi, @JamesMessinger please check the PR again. Thanks.

@JamesMessinger JamesMessinger merged commit 539326c into JS-DevTools:master Aug 29, 2020
@JamesMessinger
Copy link
Member

Thanks for the great PR, @setshaft ! 🏆💯 Sorry it took me so long to get it merged. I've been working nights and weekends for the past couple of weeks 😓, so didn't have any time to spend on personal projects

@sidtagirisa
Copy link
Contributor Author

@JamesMessinger No Problem 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce a flag to skip preversion, version and postversion
2 participants