-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option to exclude version scripts #40
Conversation
feature to skip specified version scripts from running by default with a new argument
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@setshaft - Thanks for the PR! You did a great job on this, but I'd like to go with a boolean --ignore-scripts
flag like NPM has, rather than a --skip-version-scripts
array. The array will cause conflicts/confusion with the files
variadic argument. We could take steps to mitigate that problem, but I don't think it's worthwhile, given that the primary use-case will be to skip all NPM scripts, so a simple boolean flag works.
@JamesMessinger Sure, I will make changes when I have some free time and update you on this :) |
@JamesMessinger I have made the requested changes please take a look now 😊. |
Hi, @JamesMessinger please check the PR again. Thanks. |
Thanks for the great PR, @setshaft ! 🏆💯 Sorry it took me so long to get it merged. I've been working nights and weekends for the past couple of weeks 😓, so didn't have any time to spend on personal projects |
@JamesMessinger No Problem 😊 |
implements a feature to skip specified version scripts from running by default with a new argument called --ignore-scripts which defaults to false
closes: #39