-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cross-platform support for pre/post version script hooks. #17
Add cross-platform support for pre/post version script hooks. #17
Conversation
Fix error reporting for exec function that was failing when result `stdout` and `stderr` are null (for example in case when `ENOENT` error is surfaced). Fix error reporting for bump prompt cli.
ec0f346
to
1e32718
Compare
@BigstickCarpet , what do you think? |
@szarouski - Thanks for the PR. It looks good, but if you could add a couple more things, I'd really appreciate it. Script order
Tests |
7719b2f
to
67e0340
Compare
@BigstickCarpet Ok, I'll try. First I had to make tests run on windows: https://ci.appveyor.com/project/szarouski/version-bump-prompt. I added appveyor CI (with a little bit of pain). Would you mind dropping support for node < 4? I can make it working, but it require more time and I'm not sure it is much needed. Worst case people can submit another PR. |
67e0340
to
c0d0401
Compare
@BigstickCarpet Please review again. |
@szarouski - Thanks for all your work on this. I haven't had a chance to review your latest commits yet (been too busy at work), but should be able to look at them next week. Sorry for the delay :( Thanks for adding appveyor CI. I've been meaning to do that anyway. 👍 I'm fine with dropping support for old Node versions (< 4.0). Just update the Thanks again! |
c0d0401
to
f8b6701
Compare
No problem, I'm happy to contribute 😄. I updated engines setting. |
@szarouski - I've finally got some free time, so I'm merging this PR now. Will make some additional changes and then publish it to npm as v3.0.0 |
@szarouski - v3.0.0 has been published to npm. Thanks again for your help! I gave you credit in the changelog 👍 |
Also fix error reporting for exec function that was failing when result
stdout
andstderr
are null (for example in case whenENOENT
error is surfaced). Fixes: #2