Update to pnpm (including adding pnpm support to shared-node-cache (and Cypress!)) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fdfd2e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jeremywiebe
commented
Mar 1, 2025
| @@ -5,26 +5,40 @@ inputs: | |||
| description: 'Node version to use' | |||
| required: false | |||
| default: '20.x' | |||
| cache-cypress: | |||
There was a problem hiding this comment.
I've added this option because we probably don't want to pull down the Cypress cache for jobs that aren't going to invoke Cypress.
jeremywiebe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the
Khan/shared-node-cacheaction to support our preferred package manager: pnpm! I've also included special support for Cypress as that doesn't "just work" when using anode_modulesdir restored from cache.See: https://pnpm.io/continuous-integration#github-actions
Issue: "none"
Test plan:
Integerate it into a project and test there. I'm not sure how else to test these shared actions.