[LEMS-2852] Answerless Expression #2226

handeyeco · 2025-02-11T17:32:59Z

Summary:

So the main thing with the Expression widget is that it was using answer data to determine which extraKeys to show in the MathInput keypad. For instance if a possible answer was 42i, it would show i in the Extra tab on the keypad.

This PR sets us up for removing answers by adding extraKeys to the data schema so it can be determined at publish time rather than read time. We simulate this by upgrading the widget to provide extraKeys when not present on the data.

Issue: LEMS-2852

Test plan:

Go to an Expression widget that has a constant/variable in the answer
It should render the same, including having the constant/variable in the keypad
It should be answerable/scorable

… of data

…expression-answerless

github-actions · 2025-02-11T17:36:20Z

Size Change: +205 B (+0.02%)

Total Size: 875 kB

Filename	Size	Change
`packages/math-input/dist/es/index.js`	77.7 kB	-498 B (-0.64%)
`packages/perseus-core/dist/es/index.js`	31.9 kB	+1.32 kB (+4.31%)
`packages/perseus-editor/dist/es/index.js`	276 kB	+92 B (+0.03%)
`packages/perseus/dist/es/index.js`	368 kB	-707 B (-0.19%)

ℹ️ View Unchanged

Filename	Size
`packages/kas/dist/es/index.js`	39.7 kB
`packages/keypad-context/dist/es/index.js`	760 B
`packages/kmath/dist/es/index.js`	11.1 kB
`packages/math-input/dist/es/strings.js`	1.79 kB
`packages/perseus-linter/dist/es/index.js`	22.8 kB
`packages/perseus-score/dist/es/index.js`	20.6 kB
`packages/perseus/dist/es/strings.js`	6.73 kB
`packages/pure-markdown/dist/es/index.js`	4.14 kB
`packages/simple-markdown/dist/es/index.js`	13.1 kB

_{compressed-size-action}

handeyeco · 2025-02-13T17:11:10Z

...c/parse-perseus-json/regression-tests/__snapshots__/parse-perseus-json-snapshot.test.ts.snap

+          "extraKeys": [
+            "PI",
+          ],


Maybe instead of having deriveExtraKeys default to ["PI"] it should just be empty and the props can default to ["PI"] when rendering...

packages/perseus-core/src/widgets/expression/derive-extra-keys.ts

handeyeco · 2025-02-13T18:14:02Z

packages/perseus/src/widgets/expression/expression.test.tsx

+            expect(score).toHaveBeenAnsweredCorrectly();
+        });
+
+        it("is interactive with answerless widget options", async () => {


This is the important one. Without answer data we:

Render

Answer

Send the input off for scoring

handeyeco · 2025-02-13T18:15:02Z

packages/perseus/src/widgets/expression/expression.tsx

- *       to be included as keys on the keypad. These are scraped from the answer
- *       forms.
- */
-export const keypadConfigurationForProps = (


Most of this logic was for deriving extra keys, so I just transformed this into deriveExtraKeys.

handeyeco · 2025-02-19T21:11:54Z

packages/perseus-core/src/widgets/expression/expression-upgrade.ts

+            buttonsVisible: v0options.buttonsVisible,
+            visibleLabel: v0options.visibleLabel,
+            ariaLabel: v0options.ariaLabel,
+            extraKeys: v0options.extraKeys,


Remove this

handeyeco · 2025-02-19T21:12:15Z

packages/perseus-core/src/widgets/expression/expression-upgrade.ts

+            extraKeys: v1options.extraKeys || deriveExtraKeys(v1options),
+        };
+    },
+    "1": (v0options: any): PerseusExpressionWidgetOptions => {


This probably shouldn't return PerseusExpressionWidgetOptions

Agreed. I believe long-term we won't be keeping this widget upgrade system (in favour of the new parsing system). I had a comment in the test file for this file that we could add a v1 widget options type. That's some extra work but keeps it explicit what these functions are accepting/returning. 🤷‍♂️

…expression-answerless

github-actions · 2025-02-24T22:25:54Z

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (21a7155) and published it to npm. You
can install it using the tag PR2226.

Example:

pnpm add @khanacademy/perseus@PR2226

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2226

… dep

packages/perseus-editor/src/widgets/radio/editor.tsx

…YOLO

…n editor

jeremywiebe

A bunch of thoughts and nits... but I think this makes sense as it is!

jeremywiebe · 2025-02-25T17:23:07Z

packages/perseus-core/src/data-schema.ts

+    // What extra keys need to be displayed on the keypad so that the
+    // question can be answerable without a keyboard (ie mobile)
+    // TODO: this is really ReadonlyArray<Key>
+    extraKeys?: ReadonlyArray<string>;


Can this be updated now that the types have been moved to perseus-core?

I'll make the change, but I was still a little unsure because this would be the only import into data-schema I think.

packages/perseus-core/src/keypad.ts

packages/perseus-core/src/widgets/expression/derive-extra-keys.test.ts

packages/perseus-core/src/widgets/expression/expression-upgrade.test.ts

packages/perseus-editor/src/widgets/__tests__/expression-editor.test.tsx

packages/perseus-editor/src/widgets/expression-editor.tsx

jeremywiebe · 2025-02-25T20:46:53Z

packages/perseus/src/widgets/expression/expression.test.tsx

+            });
+
+            // Assert
+            expect(result.keypadConfiguration.extraKeys).toEqual(["x"]);


Guessing this is existing logic, but I'm surprised it doesn't merge them.

packages/perseus/src/widgets/expression/expression.test.tsx

packages/perseus/src/widgets/expression/expression.tsx

…ion: Expression can render and is interactive with answerless data

@handeyeco

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/math-input@23.0.0 ### Major Changes - [#2226](#2226) [`909148cdc`](909148c) Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless Expression: Expression can render and is interactive with answerless data ### Patch Changes - Updated dependencies \[[`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus-core@5.0.0 - @khanacademy/keypad-context@1.1.1 ## @khanacademy/perseus@56.0.0 ### Major Changes - [#2233](#2233) [`a0aee41b6`](a0aee41) Thanks [@handeyeco](https://github.com/handeyeco)! - RadioWidget v2 in support of answerless Radio ### Patch Changes - [#2279](#2279) [`e02cc4109`](e02cc41) Thanks [@nishasy](https://github.com/nishasy)! - [SR] Tweak strings for Segment and Angle graphs - [#2270](#2270) [`941343ee3`](941343e) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Fixing side snapping within polygons to be keyboard accessible. - [#2226](#2226) [`909148cdc`](909148c) Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless Expression: Expression can render and is interactive with answerless data - Updated dependencies \[[`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus-core@5.0.0 - @khanacademy/math-input@23.0.0 - @khanacademy/keypad-context@1.1.1 - @khanacademy/kmath@0.4.1 - @khanacademy/perseus-linter@1.3.1 - @khanacademy/perseus-score@2.3.1 ## @khanacademy/perseus-core@5.0.0 ### Major Changes - [#2233](#2233) [`a0aee41b6`](a0aee41) Thanks [@handeyeco](https://github.com/handeyeco)! - RadioWidget v2 in support of answerless Radio - [#2226](#2226) [`909148cdc`](909148c) Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless Expression: Expression can render and is interactive with answerless data ## @khanacademy/perseus-editor@17.9.0 ### Minor Changes - [#2226](#2226) [`909148cdc`](909148c) Thanks [@handeyeco](https://github.com/handeyeco)! - Answerless Expression: Expression can render and is interactive with answerless data ### Patch Changes - [#2233](#2233) [`a0aee41b6`](a0aee41) Thanks [@handeyeco](https://github.com/handeyeco)! - RadioWidget v2 in support of answerless Radio - Updated dependencies \[[`e02cc4109`](e02cc41), [`941343ee3`](941343e), [`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus@56.0.0 - @khanacademy/perseus-core@5.0.0 - @khanacademy/math-input@23.0.0 - @khanacademy/keypad-context@1.1.1 - @khanacademy/kmath@0.4.1 - @khanacademy/perseus-linter@1.3.1 - @khanacademy/perseus-score@2.3.1 ## @khanacademy/keypad-context@1.1.1 ### Patch Changes - Updated dependencies \[[`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus-core@5.0.0 ## @khanacademy/kmath@0.4.1 ### Patch Changes - Updated dependencies \[[`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus-core@5.0.0 ## @khanacademy/perseus-linter@1.3.1 ### Patch Changes - Updated dependencies \[[`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus-core@5.0.0 ## @khanacademy/perseus-score@2.3.1 ### Patch Changes - Updated dependencies \[[`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus-core@5.0.0 - @khanacademy/kmath@0.4.1 ## @khanacademy/perseus-dev-ui@5.3.1 ### Patch Changes - Updated dependencies \[[`a0aee41b6`](a0aee41), [`909148cdc`](909148c)]: - @khanacademy/perseus-core@5.0.0 - @khanacademy/math-input@23.0.0 - @khanacademy/kmath@0.4.1 - @khanacademy/perseus-linter@1.3.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

handeyeco added 5 commits February 10, 2025 14:17

[LEMS-2852/expression-answerless] add tests

9188220

[LEMS-2852/expression-answerless] make transform work with both forms…

650702e

… of data

[LEMS-2852/expression-answerless] add default keys to deriveExtraKeys

9d4ccc5

[LEMS-2852/expression-answerless] Merge branch 'main' into LEMS-2852/…

10f510b

…expression-answerless

[LEMS-2852/expression-answerless] run lint fix

367e8e7

handeyeco self-assigned this Feb 11, 2025

handeyeco changed the title ~~[LEMS-2852/expression-answerless] make transform work with both forms of data~~ LEMS-2852 Answerless Expression Feb 11, 2025

handeyeco changed the title ~~LEMS-2852 Answerless Expression~~ [LEMS-2852] Answerless Expression Feb 11, 2025

handeyeco added 6 commits February 11, 2025 14:29

[LEMS-2852/expression-answerless] add version 2 of Expression

62b5452

[LEMS-2852/expression-answerless] add extraKeys to upgrade

9ba6f15

[LEMS-2852/expression-answerless] add extraKeys to parser

e15e375

[LEMS-2852/expression-answerless] fix expression parser and tests

fb769f2

[LEMS-2852/expression-answerless] rename variable in test

29e43ee

[LEMS-2852/expression-answerless] make tests score widgets

0cc404f

handeyeco commented Feb 13, 2025

View reviewed changes

handeyeco requested a review from jeremywiebe February 13, 2025 18:15

handeyeco commented Feb 19, 2025

View reviewed changes

handeyeco added 7 commits February 20, 2025 16:14

[LEMS-2852/expression-answerless] merge main

2db2571

[LEMS-2852/expression-answerless] Merge branch 'main' into LEMS-2852/…

3f491d8

…expression-answerless

[LEMS-2852/expression-answerless] add deps to perseus-core

5f9388d

[LEMS-2852/expression-answerless] Merge branch 'main' into LEMS-2852/…

30f042d

…expression-answerless

[LEMS-2852/expression-answerless] fix parser and tests

b77bb51

[LEMS-2852/expression-answerless] Merge branch 'main' into LEMS-2852/…

b207da1

…expression-answerless

[LEMS-2852/expression-answerless] move around keypad types

fb93d11

[LEMS-2852/expression-answerless] remove math-input as a perseus-core…

8e08204

… dep

handeyeco commented Feb 24, 2025

View reviewed changes

packages/perseus-editor/src/widgets/radio/editor.tsx Outdated Show resolved Hide resolved

handeyeco force-pushed the LEMS-2852/expression-answerless branch from 40246a0 to 8e08204 Compare February 25, 2025 14:30

handeyeco added 3 commits February 25, 2025 08:44

[LEMS-2852/expression-answerless] add extraKeys to editor serialize

890c565

[LEMS-2852/expression-answerless] add serialization test

350df02

[LEMS-2852/expression-answerless] add general serialize test because …

5086383

…YOLO

handeyeco marked this pull request as ready for review February 25, 2025 15:14

[LEMS-2852/expression-answerless] assert latest expression is added i…

9bf5bbf

…n editor

jeremywiebe approved these changes Feb 25, 2025

View reviewed changes

handeyeco added 7 commits February 25, 2025 16:30

[LEMS-2852/expression-answerless] add deriveExtraKeys to onChange

3f1c4e9

[LEMS-2852/expression-answerless] respond to Jeremy's feedback

d3f87c1

[LEMS-2852/expression-answerless] fix test

10249fa

[LEMS-2852/expression-answerless] fix type issue

59cca06

[LEMS-2852/expression-answerless] docs(changeset): Answerless Express…

9556fe2

…ion: Expression can render and is interactive with answerless data

[LEMS-2852/expression-answerless] undo accidental commit

c58a124

[LEMS-2852/expression-answerless] fix merge conflict

21a7155

handeyeco merged commit 909148c into main Mar 5, 2025
8 checks passed

handeyeco deleted the LEMS-2852/expression-answerless branch March 5, 2025 18:44

khan-actions-bot mentioned this pull request Mar 5, 2025

Version Packages #2280

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[LEMS-2852] Answerless Expression #2226

[LEMS-2852] Answerless Expression #2226

handeyeco commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

handeyeco Feb 13, 2025

handeyeco Feb 13, 2025

handeyeco Feb 13, 2025

handeyeco Feb 19, 2025

handeyeco Feb 19, 2025

jeremywiebe Feb 25, 2025

github-actions bot commented Feb 24, 2025 •

edited

Loading

jeremywiebe left a comment

jeremywiebe Feb 25, 2025

handeyeco Feb 26, 2025

jeremywiebe Feb 25, 2025

[LEMS-2852] Answerless Expression #2226

[LEMS-2852] Answerless Expression #2226

Conversation

handeyeco commented Feb 11, 2025 • edited Loading

Summary:

Test plan:

github-actions bot commented Feb 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Feb 24, 2025 • edited Loading

npm Snapshot: Published

jeremywiebe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

handeyeco commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 11, 2025 •

edited

Loading

github-actions bot commented Feb 24, 2025 •

edited

Loading