Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[control-aria-z] Temporarily adding back the default aria label for Numeric Input while we fix downstream issues. #2274

Closed
wants to merge 3 commits into from

Conversation

SonicScrewdriver
Copy link
Contributor

@SonicScrewdriver SonicScrewdriver commented Mar 4, 2025

Summary:

This tiny PR (proposal) adds back the default ariaLabel for Numeric Input, as we have several cypress tests that are failing downstream. We have looked at several possible ways around this issue, but it looks like we may need a larger fix before this work can be deployed.

Test plan:

  • Updated snapshots
  • Tests pass

@SonicScrewdriver SonicScrewdriver self-assigned this Mar 4, 2025
@SonicScrewdriver SonicScrewdriver changed the title [control-aria-z] docs(changeset): Temporarily adding back the default aria label for Numeric Input while we fix downstream issues. [control-aria-z] Temporarily adding back the default aria label for Numeric Input while we fix downstream issues. Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Size Change: +54 B (+0.01%)

Total Size: 872 kB

Filename Size Change
packages/perseus/dist/es/index.js 367 kB +54 B (+0.01%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 39.7 kB
packages/keypad-context/dist/es/index.js 760 B
packages/kmath/dist/es/index.js 11.1 kB
packages/math-input/dist/es/index.js 78.2 kB
packages/math-input/dist/es/strings.js 1.79 kB
packages/perseus-core/dist/es/index.js 29.9 kB
packages/perseus-editor/dist/es/index.js 276 kB
packages/perseus-linter/dist/es/index.js 22.8 kB
packages/perseus-score/dist/es/index.js 20.6 kB
packages/perseus/dist/es/strings.js 6.74 kB
packages/pure-markdown/dist/es/index.js 4.14 kB
packages/simple-markdown/dist/es/index.js 13.1 kB

compressed-size-action

Copy link
Contributor

github-actions bot commented Mar 4, 2025

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (42236ab) and published it to npm. You
can install it using the tag PR2274.

Example:

pnpm add @khanacademy/perseus@PR2274

If you are working in Khan Academy's webapp, you can run:

./dev/tools/bump_perseus_version.sh -t PR2274

@SonicScrewdriver SonicScrewdriver deleted the control-aria-z branch March 6, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant