feat: add setDocument(document) API function
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function currently never returns an error due to a bug on the server, see MC-1060.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This was referenced Nov 27, 2023
sidharthv96
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR: This PR is stacked on top of:
deleteDocument(documentID)API func #10, which is stacked on top ofcreateDocument(projectID)API function #9.Please change this PR to target
mainonce #10 has been merged.Add the
setDocument(document)API function to update a diagram.There's some weird behaviour with this API route. It seems to always return a HTTP 200 success result with an empty JSON
{}object, even when I send it invalid data and I can see an error message in the server logs, I've made a bug (MC-1060) for this behaviour.