Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sdk): make e2e tests more configurable #18

Merged
merged 2 commits into from
Apr 22, 2024

Conversation

aloisklink
Copy link
Contributor

@aloisklink aloisklink commented Mar 5, 2024

Currently, the @mermaidchart/sdk E2E tests are hard-coded to only test a single server and a single user account.

This PR modifies the E2E tests to load some test config variables from the TEST_MERMAIDCHART_BASE_URL and
TEST_MERMAIDCHART_PROJECT_ID environment variables, so that different mermaidchart accounts and servers can be used.

@aloisklink aloisklink requested a review from sidharthv96 March 5, 2024 23:29
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
office-plugin-site ⬜️ Ignored (Inspect) Visit Preview Mar 6, 2024 0:08am

Check the `TEST_MERMAIDCHART_BASE_URL` and
`TEST_MERMAIDCHART_PROJECT_ID` environment variables, so that different
mermaidchart accounts can be used.
@aloisklink aloisklink force-pushed the test/make-e2e-sdk-tests-more-configurable branch from 5815f19 to b062b59 Compare March 6, 2024 00:08
Base automatically changed from fix/setDocument-specify-that-projectID-is-required to main April 10, 2024 14:16
@aloisklink aloisklink marked this pull request as ready for review April 10, 2024 14:17
@aloisklink aloisklink merged commit f8a1430 into main Apr 22, 2024
4 checks passed
@aloisklink aloisklink deleted the test/make-e2e-sdk-tests-more-configurable branch April 22, 2024 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants