Add SDK #2
Add SDK #2
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
packages/google/src/Api.ts
Outdated
There was a problem hiding this comment.
In function function getOAuthService(), avoid hard-coded .setClientId('f88f1365-dea8-466e-8880-e22211e145bd')
There was a problem hiding this comment.
That is the google plugin's client ID. It needs to be hard coded. It's hard coded in the server too.
packages/google/src/Common.ts
Outdated
| @@ -46,7 +46,7 @@ export function createCatCard( | |||
| if (!isHomepage) { | |||
| // Create the header shown when the card is minimized, | |||
| // but only when this card is a contextual card. Peek headers | |||
| // are never used by non-contexual cards like homepages. | |||
| // are never used by non-contextual cards like homepages. | |||
| const peekHeader = CardService.newCardHeader() | |||
| .setTitle('Contextual Cat') | |||
| .setImageUrl('https://www.gstatic.com/images/icons/material/system/1x/pets_black_48dp.png') | |||
There was a problem hiding this comment.
Removed the function.
packages/sdk/src/index.ts
Outdated
There was a problem hiding this comment.
Overall: Some of the public functions have a header with documentation and some have not. The naming of the functions are good and as a user you will understand the purpose of the function, but I think would make sense to either skip headers or add headers for all public functions in the file
There was a problem hiding this comment.
The two functions with comments are the ones that need explanation that they should be overridden when required.
We cannot remove those comments.
There is no need to add verbose comments to each function just because some functions need comments.
|
The changes in google folder have nothing to do with the PR, they were just formatting changes when prettier was added. I've fixed the raised comments, except the one regarding adding/removing comments to/from all functions. |
No description provided.