build(sdk): build a Node.JS version of @mermaidchart/sdk
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package will now be built automatically when running `npm install` or `npm publish`.
ESM imports require a file-extension in Node.JS. TypeScript has a [node16][1] rule for this. [1]: https://www.typescriptlang.org/docs/handbook/modules/reference.html#node16-nodenext
Currently, the @mermaidchart/sdk is for browsers only, since it compiles an IIFE build. This commit adds an ESM output so we can use it for Node.JS (or even for browsers if we want to use tree-shaking).
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
sidharthv96
approved these changes
Nov 21, 2023
This was referenced Nov 21, 2023
aloisklink
changed the title
@mermaidchart/sdk@mermaidchart/sdk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
@mermaidchart/sdkpackage only builds an IIFE bundle for use in a browser.Unfortunately, this doesn't work in Node.JS, so I've instead built an ESM version for Node.JS.