Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Message field for signing messages should never auto collapse #30843

Open
SCBuergel opened this issue Mar 6, 2025 · 1 comment
Open
Labels
external-contributor needs-triage Issue needs to be triaged regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working

Comments

@SCBuergel
Copy link

Describe the bug

I am signing a msg in MM in a SIWE flow and the Message field is auto minimized. I'm convinced that making something "just one more click away" will reduce the number of people actually validating what they sign by another 50%. Even if some of this might be related to my specific Qubes setup (where windows might look different than on other OSs) this field should IMO never be minimized.

I'm on MM 12.12.0 on Brave on Debian (all updated to latest).

Expected behavior

Show the full message field that I am signing

Screenshots/Recordings

Image

Steps to reproduce

  1. Go to app.gnosispay.com
  2. Click Sign in with Wallet
  3. Wait for MM to pop up in separate window
  4. Now observe the collapsed Message field in that MM window

Error messages or log output

Detection stage

In production (default)

Version

12.12.0

Build type

None

Browser

Brave

Operating system

Other (please elaborate in the "Additional Context" section)

Hardware wallet

No response

Additional context

I'm on Debian (but via Qubes OS)

Severity

No response

@SCBuergel SCBuergel added the type-bug Something isn't working label Mar 6, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Mar 6, 2025
@github-project-automation github-project-automation bot moved this to To be triaged in Bugs by team Mar 6, 2025
@metamaskbot metamaskbot added external-contributor regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 needs-triage Issue needs to be triaged labels Mar 6, 2025
@sleepytanya sleepytanya added team-confirmations Push issues to confirmations team Sev2-normal Normal severity; minor loss of service or inconvenience. labels Mar 7, 2025
@digiwand
Copy link
Contributor

As mentioned in a standup meeting, we will default to opened messages for SIWE and personal sign
cc: @SayaGT

@digiwand digiwand assigned digiwand and unassigned digiwand Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contributor needs-triage Issue needs to be triaged regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug Something isn't working
Projects
Status: To be fixed
Status: To be triaged
Development

No branches or pull requests

4 participants