-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#58] Reconstruct UI test #60
Merged
2wheeh
merged 7 commits into
MovieReviewComment:develop
from
2wheeh:feature/issue-58/reconstruct-ui-test
Sep 28, 2023
Merged
[#58] Reconstruct UI test #60
2wheeh
merged 7 commits into
MovieReviewComment:develop
from
2wheeh:feature/issue-58/reconstruct-ui-test
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d92413
to
64cc153
Compare
64cc153
to
b3ab3db
Compare
2wheeh
commented
Sep 25, 2023
skgndi12
reviewed
Sep 26, 2023
ui/packages/common-components/src/molecule/MolecularComponent/MolecularComponent.test.tsx
Outdated
Show resolved
Hide resolved
skgndi12
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다! 👍
ui/packages/common-components/src/molecule/MolecularComponent/MolecularComponent.test.tsx
Outdated
Show resolved
Hide resolved
isutare412
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
설명이 상세해서 PR 보기가 편하네요.
고생 많으셨습니다 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
ui
Something about UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #58
Changes
각 프로젝트의
test
스크립트가 동작합니다.mr-c.app
:jest
withnextjs
jest
의typescript
실행을 위해 별도의 파이프라인을 추가하지 않고nextjs
의 컴파일러를 이용합니다.common-components
:vitest
withvite
,storybook
vite
의 컴파일 파이프라인을 공유할 수 있는vitest
로 테스트를 실행합니다.storybook
을 위해 작성한story
를 테스트 작성 시에 사용할 수 있습니다.common-utils
:jest
withts-jest
jest
의typescript
실행을 위해ts-jest
라이브러리를 사용합니다.mrc-ui
루트의test:
스크립트가 동작합니다.workspace-tools
플러그인의foreach
커맨드를 사용하여UI 테스트 워크플로를 재구성합니다.
ui-test
를 별도의 파일로 분리합니다.ui-test
워크플로는test:affected
스크립트를 실행하며 기대하는 동작은 다음과 같습니다:dependent
) 를 순회하며test
스크립트를 실행한다.Additional Info
tsconfig
,lint
설정이 아직 작업 중 입니다. 관련된 기능이 정상적으로 동작하지 않을 수 있습니다.