Port MASTG-TEST-0006: Determining Whether the Keyboard Cache Is Disabled for Text Input Fields (android) (by @guardsquare) #3055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpholguera
reviewed
Nov 7, 2024
cpholguera
reviewed
Nov 7, 2024
cpholguera
reviewed
Nov 7, 2024
There was a problem hiding this comment.
there's an explanation potentially missing here
we need to indicate that these attributes can appear as e.g. textPassword or TYPE_TEXT_VARIATION_PASSWORD depending on ...
This is sth. I would not have in the theory but rather in the test because it directly affect how we're going to test.
There was a problem hiding this comment.
I added the explanation in the latest commit. PLease have a look
cpholguera
requested changes
Nov 7, 2024
…rence between them
cpholguera
requested changes
Jan 30, 2025
cpholguera
changed the title
Co-authored-by: Carlos Holguera <perezholguera@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #2936.