Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor child communication to own module #2728

Merged
merged 7 commits into from
Mar 4, 2025

Conversation

juanscr
Copy link
Contributor

@juanscr juanscr commented Feb 20, 2025

Description

This pull request refactors all the child communication to an isolated module. Although this allows for clear and independent separation for how child proxying works, this is mostly done so in a next PR we can tree shake this module with a feature flag. There is no particular functionality change introduced in this pull request.

Main changes in the PR:

  1. Refactor child communication to an isolated module.
  2. Added proper unit tests to detail how child proxying and child event relaying works.

Validation

Validation performed:

  1. Ran set of tests.
  2. Ran child app to see if everything worked as usual.

Unit Tests added:

Yes

End-to-end tests added:

No

Additional Requirements

Change file added:

Yes

Next/remaining steps:

A follow-up PR will make add a feature flag for using this module, which would then make it so all child proxying code is removed in the final bundle if not needed.

@juanscr juanscr requested a review from a team as a code owner February 20, 2025 23:50
@juanscr juanscr force-pushed the juancard/refactorChildProxying branch from 7129f19 to 90d71e0 Compare February 20, 2025 23:55
Copy link
Contributor

github-actions bot commented Feb 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/teams-js/dist/esm/packages/teams-js/src/index.js 180.51 KB (+0.05% 🔺) 3.7 s (+0.05% 🔺) 198 ms (-4.67% 🔽) 3.9 s

@juanscr juanscr requested a review from jekloudaMSFT February 24, 2025 17:06
Copy link
Contributor

@noahdarveau-MSFT noahdarveau-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits and questions to clarify my own understanding, but otherwise looks good to me.

@juanscr juanscr enabled auto-merge (squash) February 27, 2025 16:04
@juanscr juanscr merged commit 7dd14f0 into main Mar 4, 2025
58 checks passed
@juanscr juanscr deleted the juancard/refactorChildProxying branch March 4, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants