Add "authId" and "connectionName" properties to ExternalAppAuthenticationForCEA.authenticateWithSSOAndResendRequest #2729
+48
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
| @@ -161,6 +161,8 @@ const AuthenticateWithSSOAndResendRequestForCEA = (): React.ReactElement => | |||
| conversationId: string; | |||
| authTokenRequest: externalAppAuthentication.AuthTokenRequestParameters; | |||
| originalRequestInfo: externalAppAuthentication.IActionExecuteInvokeRequest; | |||
| authId: string; | |||
There was a problem hiding this comment.
Can authId and connectionName be part of an interface that extends AuthTokenRequestParameters?
…ibrary-js into jeklouda/updateCeaAuth
ndangudubiyyam
approved these changes
Feb 22, 2025
…ibrary-js into jeklouda/updateCeaAuth
lakhveerk
reviewed
Feb 27, 2025
maglims
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more information about how to contribute to this repo, visit this page.
Description
This PR adds "authId" and "connectionName" parameters to the
ExternalAppAuthenticationForCEA.authenticateWithSSOAndResendRequestAPI. These parameters are required from the app to complete the original request.Main changes in the PR:
authenticateWithSSOAndResendRequestfunction inpackages/teams-js/src/private/externalAppAuthenticationForCEA.ts.Validation
Validation performed:
Unit Tests added:
Yes, updated existing tests to use new parameters
End-to-end tests added:
No, added on host SDK
Additional Requirements
Change file added:
Yes