[#20718] [Java] fixed code generation for jersey2/3 and okhttp-gson when using modelMapping with a package and anyOf/oneOf #20721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue-20718 fixed code generation for jersey2/3 and okhttp-gson when using modelMapping with a package and anyOf/oneOf
Added a method to get a sanitized dataType string
Added sanitation when the datatype is used in variable names in the Jersey2/Jersey3/OkHttp-Gson mustache files for anyOf and oneOf
Added 1 test that tests the sanitizing method itself
Added 3 tests for the combination anyOf & oneOf with jersey2, jersey3 and okhttp-gson
Since the fix has a problem with mappedSchema's I decided to add a separate file, since adding to the fake petstore would make it necessary to add a mapping to all tests that currently use it.
The sanitation consists of:
The sanitize method is then used in the mustache files, when the dataType would be used as a variable name or in the name of a method.
The changes only impact the Java code generation:
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
Since it introduces a feature/but does not introduce a change in any behaviour, this commit is imho a minor version change.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)