-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 20804: Add java nullability annotations #20806
base: master
Are you sure you want to change the base?
Issue 20804: Add java nullability annotations #20806
Conversation
Motivation: Be able to use generated clients in code checked by tools like NullAway.
Motivation: Be able to use generated clients in code checked by tools like NullAway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nvervelle, thanks for the PR! I have only one tiny little remark - please see below.
@@ -2609,16 +2609,17 @@ public void testRestClientFormMultipart() { | |||
TestUtils.assertFileContains( | |||
output.resolve("src/main/java/xyz/abcdef/api/MultipartApi.java"), | |||
// multiple files | |||
"multipartArray(List<File> files)", | |||
"multipartArray(@jakarta.annotation.N", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion is anyway covered by the line below, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @martin-mfg, yes, this was temporary test code to find more easily what annotations were used in each case because TestUtils.assertFileContains()
doesn't output the file contents if it fails.
It's fixed.
Motivation: Be able to use generated clients in code checked by tools like NullAway.
Hi @wing328 : is the PR ok for you and can it be merged ? |
Motivations:
Have generated clients annotated for nullability to be able to check code using them with tools like NullAway (to close #20804)
Modifications:
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming7.x.0
minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)