reworked RecordModuleCommand function and started runningprotocolcommand #51828
rclarke0Annotations
15 errors and 10 warnings
|
js checks:
app/src/organisms/ODD/RunningProtocol/CurrentRunningProtocolCommand.tsx#L169
Property 'moduleId' does not exist on type '{} | AspirateInPlaceParams | PipetteIdentityParams | AspDispAirgapParams | BlowoutInPlaceParams | BlowoutParams | ConfigureForVolumeParams | DispenseInPlaceParams | DispenseParams | DropTipInPlaceParams | DropTipParams | MoveToAddressableAreaForDropTipParams | TouchTipParams | VerifyTipPresenceParams | (WellLocationParam & PipetteAccessParams) | AirGapInPlaceParams | HomeParams | MoveRelativeParams | MoveToAddressableAreaParams | MoveToCoordinatesParams | MoveToSlotParams | MoveToWellParams | RetractAxisParams | SavePositionParams | EngageMagnetParams | ModuleOnlyParams | TemperatureParams | TemperatureModuleAwaitTemperatureParams | ThermocyclerSetTargetBlockTemperatureParams | TCProfileParams | TCExtendedProfileParams | ShakeSpeedParams | AbsorbanceReaderInitializeParams | ConfigureNozzleLayoutParams | LoadLabwareParams | { labwareId: string; } | LoadLiquidParams | MoveLabwareParams | WaitForResumeParams | WaitForDurationParams | DeprecatedDelayParams | CalibratePipetteParams | CalibrateGripperParams | CalibrateModuleParams | MoveToMaintenancePositionParams | CommentParams | CustomParams | SetStatusBarParams | SetRailLightsParams | UnsafeBlowoutInPlaceParams | UnsafeDropTipInPlaceParams | UnsafeUpdatePositionEstimatorsParams | UnsafePlaceLabwareParams | (LoadModuleParams & { model: ModuleModel; }) | (LoadPipetteParams & { pipetteName: "p10_single" | "p10_multi" | "p20_single_gen2" | "p20_multi_gen2" | "p50_single" | "p50_multi" | "p300_single" | "p300_single_gen2" | "p300_multi" | "p300_multi_gen2" | "p1000_single" | "p1000_single_gen2" | "p1000_single_flex" | "p50_single_flex" | "p1000_multi_flex" | "p1000_multi_em_flex" | "p50_multi_flex" | "p1000_96" | "p200_96"; })'.
|
|
js checks:
app/src/organisms/ODD/RunningProtocol/CurrentRunningProtocolCommand.tsx#L172
Type 'RunCommandError | null | undefined' is not assignable to type 'string | undefined'.
|
|
js checks:
app/src/organisms/ODD/RunningProtocol/CurrentRunningProtocolCommand.tsx#L173
Property 'moduleId' does not exist on type '{} | AspirateInPlaceParams | PipetteIdentityParams | AspDispAirgapParams | BlowoutInPlaceParams | BlowoutParams | ConfigureForVolumeParams | DispenseInPlaceParams | DispenseParams | DropTipInPlaceParams | DropTipParams | MoveToAddressableAreaForDropTipParams | TouchTipParams | VerifyTipPresenceParams | (WellLocationParam & PipetteAccessParams) | AirGapInPlaceParams | HomeParams | MoveRelativeParams | MoveToAddressableAreaParams | MoveToCoordinatesParams | MoveToSlotParams | MoveToWellParams | RetractAxisParams | SavePositionParams | EngageMagnetParams | ModuleOnlyParams | TemperatureParams | TemperatureModuleAwaitTemperatureParams | ThermocyclerSetTargetBlockTemperatureParams | TCProfileParams | TCExtendedProfileParams | ShakeSpeedParams | AbsorbanceReaderInitializeParams | ConfigureNozzleLayoutParams | LoadLabwareParams | { labwareId: string; } | LoadLiquidParams | MoveLabwareParams | WaitForResumeParams | WaitForDurationParams | DeprecatedDelayParams | CalibratePipetteParams | CalibrateGripperParams | CalibrateModuleParams | MoveToMaintenancePositionParams | CommentParams | CustomParams | SetStatusBarParams | SetRailLightsParams | UnsafeBlowoutInPlaceParams | UnsafeDropTipInPlaceParams | UnsafeUpdatePositionEstimatorsParams | UnsafePlaceLabwareParams | (LoadModuleParams & { model: ModuleModel; }) | (LoadPipetteParams & { pipetteName: "p10_single" | "p10_multi" | "p20_single_gen2" | "p20_multi_gen2" | "p50_single" | "p50_multi" | "p300_single" | "p300_single_gen2" | "p300_multi" | "p300_multi_gen2" | "p1000_single" | "p1000_single_gen2" | "p1000_single_flex" | "p50_single_flex" | "p1000_multi_flex" | "p1000_multi_em_flex" | "p50_multi_flex" | "p1000_96" | "p200_96"; })'.
|
|
js checks:
app/src/organisms/ODD/RunningProtocol/CurrentRunningProtocolCommand.tsx#L174
Property 'celsius' does not exist on type '{} | AspirateInPlaceParams | PipetteIdentityParams | AspDispAirgapParams | BlowoutInPlaceParams | BlowoutParams | ConfigureForVolumeParams | DispenseInPlaceParams | DispenseParams | DropTipInPlaceParams | DropTipParams | MoveToAddressableAreaForDropTipParams | TouchTipParams | VerifyTipPresenceParams | (WellLocationParam & PipetteAccessParams) | AirGapInPlaceParams | HomeParams | MoveRelativeParams | MoveToAddressableAreaParams | MoveToCoordinatesParams | MoveToSlotParams | MoveToWellParams | RetractAxisParams | SavePositionParams | EngageMagnetParams | ModuleOnlyParams | TemperatureParams | TemperatureModuleAwaitTemperatureParams | ThermocyclerSetTargetBlockTemperatureParams | TCProfileParams | TCExtendedProfileParams | ShakeSpeedParams | AbsorbanceReaderInitializeParams | ConfigureNozzleLayoutParams | LoadLabwareParams | { labwareId: string; } | LoadLiquidParams | MoveLabwareParams | WaitForResumeParams | WaitForDurationParams | DeprecatedDelayParams | CalibratePipetteParams | CalibrateGripperParams | CalibrateModuleParams | MoveToMaintenancePositionParams | CommentParams | CustomParams | SetStatusBarParams | SetRailLightsParams | UnsafeBlowoutInPlaceParams | UnsafeDropTipInPlaceParams | UnsafeUpdatePositionEstimatorsParams | UnsafePlaceLabwareParams | (LoadModuleParams & { model: ModuleModel; }) | (LoadPipetteParams & { pipetteName: "p10_single" | "p10_multi" | "p20_single_gen2" | "p20_multi_gen2" | "p50_single" | "p50_multi" | "p300_single" | "p300_single_gen2" | "p300_multi" | "p300_multi_gen2" | "p1000_single" | "p1000_single_gen2" | "p1000_single_flex" | "p50_single_flex" | "p1000_multi_flex" | "p1000_multi_em_flex" | "p50_multi_flex" | "p1000_96" | "p200_96"; })'.
|
|
js checks
Process completed with exit code 2.
|
|
js checks:
app/src/organisms/ModuleCard/TemperatureModuleSlideout.tsx#L44
React Hook "useModuleCommandAnalytics" is called in function "handleSubmitTemperature" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"
|
|
js checks:
app/src/organisms/ModuleCard/hooks.tsx#L227
React Hook "useModuleCommandAnalytics" is called in function "handleDeactivationCommand" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"
|
|
js checks:
app/src/organisms/ODD/ProtocolSetup/ProtocolSetupLabware/index.tsx#L319
React Hook "useModuleCommandAnalytics" is called in function "toggleLatch" that is neither a React function component nor a custom React Hook function. React component names must start with an uppercase letter. React Hook names must start with the word "use"
|
|
js checks:
app/src/organisms/ODD/RunningProtocol/CurrentRunningProtocolCommand.tsx#L166
For-in loops over arrays skips holes, returns indices as strings, and may visit the prototype chain or other enumerable properties. Use a more robust iteration method such as for-of or array.forEach instead
|
|
js checks:
app/src/redux-resources/analytics/hooks/useModuleAnalytics.ts#L1
Import "AttachedModule" is only used as types
|
|
js checks:
app/src/redux-resources/analytics/hooks/useModuleAnalytics.ts#L1
'CommandData' is defined but never used
|
|
js checks:
app/src/redux-resources/analytics/hooks/useModuleAnalytics.ts#L1
'RUN_STATUS_FAILED' is defined but never used
|
|
js checks:
app/src/redux-resources/analytics/hooks/useModuleAnalytics.ts#L1
'RUN_STATUS_SUCCEEDED' is defined but never used
|
|
js checks:
app/src/redux-resources/analytics/hooks/useModuleAnalytics.ts#L2
'useState' is defined but never used
|
|
js checks:
app/src/redux-resources/analytics/hooks/useModuleAnalytics.ts#L10
'CreateLiveCommandMutateParams' is defined but never used
|
|
js checks:
api-client/src/pipettes/types.ts#L62
A record is preferred over an index signature
|
|
js checks:
api-client/src/pipettes/types.ts#L69
A record is preferred over an index signature
|
|
js checks:
api-client/src/pipettes/types.ts#L77
A record is preferred over an index signature
|
|
js checks:
api-client/src/pipettes/types.ts#L81
A record is preferred over an index signature
|
|
js checks:
api-client/src/pipettes/types.ts#L90
A record is preferred over an index signature
|
|
js checks:
api-client/src/types.ts#L14
A record is preferred over an index signature
|
|
js checks:
app-shell-odd/src/actions.ts#L360
Expected property shorthand
|
|
js checks:
app-shell-odd/src/actions.ts#L368
Expected property shorthand
|
|
js checks:
app-shell-odd/src/actions.ts#L376
Expected property shorthand
|
|
js checks:
app-shell-odd/src/actions.ts#L384
Expected property shorthand
|