Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol-designer, components): add retract for aspirate and dispense to PD #17411

Merged
merged 29 commits into from
Feb 26, 2025

Conversation

syao1226
Copy link
Collaborator

@syao1226 syao1226 commented Feb 4, 2025

re AUTH-906, AUTH-907

Overview

In this PR, I created a new MultiInputField component for the Submerge and Retract sections in the transfer steps, as they share a similar UI design with multiple InputStepFormFields. Additionally, I updated the PositionField and added a new type to the ListButton component to support a white button for the updated well position button design.

Test Plan and Hands on Testing

Changelog

  • Created a new MultiInputField component: multiple InputStepFormFields and an optional PositionField button
  • Added a new type onColor to ListButton
  • Added new prefix values to MoveLiquidPrefixType and added retract xyz position fields to form-types
  • Added new retract fields to 8_5_0 migration file and updated the fixtures
  • Added unit tests

Review requests

Risk assessment

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 72.80000% with 68 lines in your changes missing coverage. Please review.

Project coverage is 27.26%. Comparing base (f0b21f7) to head (49ada9c).
Report is 15 commits behind head on edge.

Files with missing lines Patch % Lines
...ols/MoveLiquidTools/SecondStepsMoveLiquidTools.tsx 0.00% 41 Missing ⚠️
...ocolSteps/StepForm/PipetteFields/PositionField.tsx 0.00% 21 Missing ⚠️
protocol-designer/src/load-file/migration/8_5_0.ts 0.00% 4 Missing ⚠️
...src/pages/Designer/ProtocolSteps/StepForm/utils.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17411      +/-   ##
==========================================
+ Coverage   25.65%   27.26%   +1.60%     
==========================================
  Files        2840     3194     +354     
  Lines      218559   233244   +14685     
  Branches    17945    10701    -7244     
==========================================
+ Hits        56067    63585    +7518     
- Misses     162477   169630    +7153     
- Partials       15       29      +14     
Flag Coverage Δ
protocol-designer 18.93% <73.09%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/atoms/ListButton/index.tsx 92.64% <ø> (-3.72%) ⬇️
protocol-designer/src/form-types.ts 73.52% <ø> (-7.12%) ⬇️
...-designer/src/organisms/TipPositionModal/index.tsx 90.44% <100.00%> (ø)
...-designer/src/organisms/TipPositionModal/utils.tsx 90.41% <100.00%> (+0.27%) ⬆️
...gner/ProtocolSteps/StepForm/PipetteFields/utils.ts 2.29% <ø> (ø)
...Form/StepTools/MoveLiquidTools/MultiInputField.tsx 100.00% <100.00%> (ø)
protocol-designer/src/resources/types.ts 100.00% <100.00%> (ø)
protocol-designer/src/resources/utils/index.ts 100.00% <100.00%> (ø)
...src/step-forms/test/createPresavedStepForm.test.ts 98.30% <100.00%> (-1.70%) ⬇️
...r/src/steplist/formLevel/getDefaultsForStepType.ts 91.00% <100.00%> (-1.98%) ⬇️
... and 6 more

... and 522 files with indirect coverage changes

@syao1226 syao1226 changed the title feat(protocol-designer): add retract for aspirate and dispense to PD feat(protocol-designer, components): add retract for aspirate and dispense to PD Feb 7, 2025
@syao1226 syao1226 marked this pull request as ready for review February 10, 2025 20:44
@syao1226 syao1226 requested review from a team as code owners February 10, 2025 20:44
@syao1226 syao1226 requested review from smb2268, koji and ncdiehl11 and removed request for a team and smb2268 February 10, 2025 20:44
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits. I will re-review once you merge edge

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple of comments
lgtm

@syao1226 syao1226 merged commit 1bcbccb into edge Feb 26, 2025
60 checks passed
@syao1226 syao1226 deleted the pd-retract branch February 26, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants