-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer, components): add retract for aspirate and dispense to PD #17411
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17411 +/- ##
==========================================
+ Coverage 25.65% 27.26% +1.60%
==========================================
Files 2840 3194 +354
Lines 218559 233244 +14685
Branches 17945 10701 -7244
==========================================
+ Hits 56067 63585 +7518
- Misses 162477 169630 +7153
- Partials 15 29 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
...gner/src/pages/Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/MultiInputField.tsx
Outdated
Show resolved
Hide resolved
...Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/__tests__/MultiInputField.test.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PositionField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PositionField.tsx
Outdated
Show resolved
Hide resolved
...Designer/ProtocolSteps/StepForm/StepTools/MoveLiquidTools/__tests__/MultiInputField.test.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits. I will re-review once you merge edge
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/PositionField.tsx
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/utils.ts
Outdated
Show resolved
Hide resolved
protocol-designer/src/pages/Designer/ProtocolSteps/StepForm/PipetteFields/utils.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a couple of comments
lgtm
re AUTH-906, AUTH-907
Overview
In this PR, I created a new
MultiInputField
component for the Submerge and Retract sections in the transfer steps, as they share a similar UI design with multipleInputStepFormFields
. Additionally, I updated thePositionField
and added a new type to theListButton
component to support a white button for the updated well position button design.Test Plan and Hands on Testing
Changelog
MultiInputField
component: multipleInputStepFormFields
and an optionalPositionField
buttononColor
toListButton
MoveLiquidPrefixType
and added retract xyz position fields toform-types
Review requests
Risk assessment