Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(shared-data): Add filtered tip to liquid-classes definitions, copying non-filtered values #17529

Conversation

andySigler
Copy link
Contributor

Overview

This PR simply copies the settings for non-filtered tips and applies them to filtered tips.

We should continue to copy any/all updates to liquid-class parameters to both the filtered and non-filtered tips.

NOTE: Before final release we may want to differentiate the correctioByVolume between the filtered/non-filtered tip-types because there may be significant %D differences 1uL. TBD until testing.

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

@andySigler andySigler requested a review from a team as a code owner February 14, 2025 15:27
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.16%. Comparing base (e4b1716) to head (a3ff6d8).
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17529   +/-   ##
=======================================
  Coverage   26.16%   26.16%           
=======================================
  Files        2835     2835           
  Lines      217746   217746           
  Branches     9276     9276           
=======================================
  Hits        56976    56976           
  Misses     160753   160753           
  Partials       17       17           
Flag Coverage Δ
protocol-designer 18.85% <ø> (ø)
step-generation 4.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sanni-t sanni-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check any changes to values since you know those better but the additions looks good; no accidental removal or duplication of any tip types 👍

@andySigler andySigler merged commit 4952cb5 into edge Mar 3, 2025
70 checks passed
@andySigler andySigler deleted the chore-shared-data-liquid-class-copy-settings-to-filtered-tips branch March 3, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants