fix(protocol-designer) modify the drag preview position #17576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify drag preview position close AUTH-1469
|
It seems a bit buggy. You can't select the top part of the labware to drag. I wonder if react dnd provides an API to move the svg relative to where the cursor is positioned? I will do some digging |
koji
changed the base branch from
chore_release-pd-8.4.1
to
chore_release-pd-8.4.3
ncdiehl11
approved these changes
Mar 6, 2025
| @@ -9,51 +9,97 @@ import { | |||
| } from '@opentrons/components' | |||
| import { DND_TYPES } from '../../../../constants' | |||
| import { DECK_CONTROLS_STYLE } from '../constants' | |||
| import previewImage from '../../../../assets/images/preview.svg' | |||
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.4.3 #17576 +/- ##
=========================================================
Coverage ? 17.79%
=========================================================
Files ? 3075
Lines ? 221782
Branches ? 6866
=========================================================
Hits ? 39467
Misses ? 182315
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
[before]
drag_and_drop_before.mov
[after]
drag_and_drop_after.mov
At this moment, the design team and the product team approved this update.
I think further improvement would need the design team's input.
close AUTH-1469
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low