Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add LPC redesigned "Before Beginning" step view #17584

Merged
merged 3 commits into from
Feb 26, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 25, 2025

Closes EXEC-1124

Overview

Adds the new "Before Beginning" view to LPC. Very straightforward, only one real thing worth mentioning:

This requires updating the DescriptionContent molecule to support special message prop styling, because the string used in message may contain special HTML tags that require special parsing (in this instance, using block tags as <p> elements). The general pattern we have used in the past is to allow message-esque props to support a string or a ReactNode, but if we'd rather just use ReactNode, I'm amenable to that.

Screenshot 2025-02-25 at 2 27 05 PM

Test Plan and Hands on Testing

  • See screenshot.
  • Covered by added testing.

Changelog

  • Added updated "Before Beginning" step to LPC.

Risk assessment

low, just copy changes

Sometimes content text contains blocks, line breaks, etc. DescriptionContent needs to be able to
accomodate various texts in a relatively unopinionated way. Allowing description content to  be of
type ReactNode is the most straightforward way.
@mjhuff mjhuff requested review from sfoster1, SyntaxColoring and a team February 25, 2025 19:50
@mjhuff mjhuff requested a review from a team as a code owner February 25, 2025 19:50
@mjhuff mjhuff requested review from smb2268 and removed request for a team and smb2268 February 25, 2025 19:50
@mjhuff mjhuff force-pushed the app_lpc-redesign-before-beginning branch from 3da3331 to ef24d80 Compare February 25, 2025 20:09
Copy link

codecov bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.

Project coverage is 24.75%. Comparing base (6546cd4) to head (ef24d80).
Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
...sms/LabwarePositionCheck/steps/BeforeBeginning.tsx 0.00% 42 Missing ⚠️
...nisms/LabwarePositionCheck/LPCContentContainer.tsx 0.00% 13 Missing ⚠️
...rganisms/LabwarePositionCheck/LPCRobotInMotion.tsx 0.00% 11 Missing ⚠️
...molecules/InterventionModal/DescriptionContent.tsx 0.00% 7 Missing ⚠️
...organisms/LegacyLabwarePositionCheck/CheckItem.tsx 0.00% 1 Missing ⚠️
...s/LegacyLabwarePositionCheck/IntroScreen/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17584      +/-   ##
==========================================
- Coverage   25.65%   24.75%   -0.90%     
==========================================
  Files        2840     2841       +1     
  Lines      218569   218645      +76     
  Branches    17942    17943       +1     
==========================================
- Hits        56068    54132    -1936     
- Misses     162486   164499    +2013     
+ Partials       15       14       -1     
Flag Coverage Δ
app 2.51% <0.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...organisms/LegacyLabwarePositionCheck/CheckItem.tsx 0.00% <0.00%> (ø)
...s/LegacyLabwarePositionCheck/IntroScreen/index.tsx 0.00% <0.00%> (ø)
...molecules/InterventionModal/DescriptionContent.tsx 0.00% <0.00%> (ø)
...rganisms/LabwarePositionCheck/LPCRobotInMotion.tsx 0.00% <0.00%> (ø)
...nisms/LabwarePositionCheck/LPCContentContainer.tsx 0.00% <0.00%> (ø)
...sms/LabwarePositionCheck/steps/BeforeBeginning.tsx 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I kind of hate typeof but I guess there's not much else we can do.

@mjhuff mjhuff merged commit 7fdb309 into edge Feb 26, 2025
40 checks passed
@mjhuff mjhuff deleted the app_lpc-redesign-before-beginning branch February 26, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants