fix(protocol-designer): fix whitescreen after deleting labware #17586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes a whitescreen produced by the `StepSummary` component for mix steps whose target labware was deleted. There was a missing optional chaining when attempting to access the labware definition's ordering. If the labware entity is null, we should not check the definition. Closes RQA-3916
koji
approved these changes
Feb 25, 2025
alexjoel42
pushed a commit
that referenced
this pull request
Feb 27, 2025
This PR fixes a whitescreen produced by the `StepSummary` component for mix steps whose target labware was deleted. There was a missing optional chaining when attempting to access the labware definition's ordering. If the labware entity is null, we should not check the definition. Closes RQA-3916 Closes AUTH-1377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes a whitescreen produced by the
StepSummarycomponent for mix steps whose target labware was deleted. There was a missing optional chaining when attempting to access the labware definition's ordering. If the labware entity is null, we should not check the definition.TODO: confirm with design whether to show StepSummary at all if some data is missing
Closes RQA-3916
Closes AUTH-1377
Test Plan and Hands on Testing
before:
Screen.Recording.2025-02-25.at.6.23.08.PM.mov
after:
Screen.Recording.2025-02-25.at.6.21.43.PM.mov
Changelog
Review requests
Risk assessment
low