Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): prevent liquid handling steps if no compatible labware #17587

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 26, 2025

Overview

This PR refines AddStepButton's supported steps logic for mix and moveLiquid, by checking the presence of compatible labware during the creation of the step. These two liquid handling options should only be shown if:

  1. the labware is on deck
  2. the labware is not an adapter
  3. the labware is not a tiprack

Closes RQA-3409

Test Plan and Hands on Testing

Case 1 - labware available

  • create or import a protocol whose final state includes liquid handling-compatible labware on deck
  • verify that the add step button menu shows transfer and mix steps

Case 2 - labware unavailable

  • delete or move all liquid handling-compatible labware off deck
  • verify that the add step button menu does not show transfer and mix steps
  • navigate to starting deck state, and add an adapter to the deck
  • verify that the add step button menu still does not show transfer and mix steps
  • navigate to starting deck state, and add a tiprack to the deck
  • verify that the add step button menu still does not show transfer and mix steps

Changelog

  • update AddStepButton logic for enabled steps
  • update util, constants, and tests

Review requests

see test plan

Risk assessment

low-medium. want to be sure we don't accidentally hide those two steps unintentionally

…e labware

This PR refines `AddStepButton`'s supported steps logic for mix and moveLiquid, by checking the presence of compatible labware during the creation of the step. These two liquid handling options should only be shown if 1) the labware is on deck, 2) the labware is not an adapter, and 3) the labware is not a tiprack.

Closes RQA-3409
@ncdiehl11 ncdiehl11 requested review from koji and syao1226 February 26, 2025 01:39
@ncdiehl11 ncdiehl11 self-assigned this Feb 26, 2025
@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 26, 2025 01:43
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 26, 2025 01:43
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes look good and sandbox worked as expected

@ncdiehl11 ncdiehl11 merged commit 8b925f6 into chore_release-pd-8.4.3 Feb 26, 2025
24 checks passed
@ncdiehl11 ncdiehl11 deleted the fix_pd-addstepbutton branch February 26, 2025 17:01
alexjoel42 pushed a commit that referenced this pull request Feb 27, 2025
…e labware (#17587)

This PR refines `AddStepButton`'s supported steps logic for mix and
moveLiquid, by checking the presence of compatible labware during the
creation of the step. These two liquid handling options should only be
shown if:
1) the labware is on deck
2) the labware is not an adapter
3) the labware is not a tiprack

Closes RQA-3409

rebasing and general conflict handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants