chore(pd): move tests and actions changed into chore_release-pd #17588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.4.3 #17588 +/- ##
=========================================================
Coverage ? 18.58%
=========================================================
Files ? 2740
Lines ? 211530
Branches ? 6522
=========================================================
Hits ? 39322
Misses ? 172208
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
reviewed
Feb 26, 2025
y3rsh
commented
Feb 26, 2025
Comment on lines
+400
to
+406
| /** | ||
| * "Rename Mix step" | ||
| */ | ||
| Rename: (): StepThunk => ({ | ||
| call: () => { | ||
| cy.log('Renaming Mix Step ---------------------------') | ||
| cy.get(MixLocators.RenameBtn).should('exist').should('be.visible').click() |
There was a problem hiding this comment.
Having the docstring on top of the function lets you see it in your IDE.
cy.log gets the description into they Cypress UI so you may easily read which function you are in when composing or fixing tests.
alexjoel42
added a commit
that referenced
this pull request
Feb 26, 2025
…#17588 chore(pd): to refactor again
alexjoel42
approved these changes
Feb 26, 2025
koji
reviewed
Feb 26, 2025
| comment: | ||
| # add flags to `layout` configuration to show up in the PR comment | ||
| layout: 'reach, diff, flags, files' | ||
| - '**/*.{mjs,css,cjs,mts}' |
koji
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get tests running against current PD work
This pull request is to get our release branches for pd using the latest Cypress tests and to use the latest PD workflow and code coverage settings.