Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add LPC redesigned "Attach Probe" step view #17589

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 26, 2025

Closes EXEC-1125 and EXEC-1190

Overview

Adds the redesigned "attach probe" view and the accompanying "probe not detected" view. This is just a plain ol' React + styling PR.

Screenshot 2025-02-26 at 9 08 59 AM Screenshot 2025-02-26 at 10 06 28 AM

Test Plan and Hands on Testing

  • See screenshots.
  • Views covered by testing.

Changelog

  • Updated "attach probe" view for redesigned LPC.

Risk assessment

low

@mjhuff mjhuff requested a review from a team as a code owner February 26, 2025 15:24
@mjhuff mjhuff requested review from jerader and removed request for a team February 26, 2025 15:24
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 66 lines in your changes missing coverage. Please review.

Project coverage is 24.75%. Comparing base (7fdb309) to head (6429dd1).

Files with missing lines Patch % Lines
...ganisms/LabwarePositionCheck/steps/AttachProbe.tsx 0.00% 33 Missing ⚠️
...nisms/LabwarePositionCheck/LPCProbeNotAttached.tsx 0.00% 32 Missing ⚠️
...ganisms/LegacyLabwarePositionCheck/AttachProbe.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17589      +/-   ##
==========================================
- Coverage   25.64%   24.75%   -0.90%     
==========================================
  Files        2841     2841              
  Lines      218631   218683      +52     
  Branches    17944    17942       -2     
==========================================
- Hits        56077    54129    -1948     
- Misses     162539   164540    +2001     
+ Partials       15       14       -1     
Flag Coverage Δ
app 2.51% <0.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...eck/hooks/useLPCCommands/useHandleProbeCommands.ts 0.00% <ø> (ø)
...ganisms/LegacyLabwarePositionCheck/AttachProbe.tsx 0.00% <0.00%> (ø)
...nisms/LabwarePositionCheck/LPCProbeNotAttached.tsx 0.00% <0.00%> (ø)
...ganisms/LabwarePositionCheck/steps/AttachProbe.tsx 0.00% <0.00%> (ø)

... and 28 files with indirect coverage changes

@mjhuff mjhuff requested review from sfoster1, SyntaxColoring and a team and removed request for jerader February 26, 2025 15:24
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray

@mjhuff mjhuff merged commit 8fe0be1 into edge Feb 26, 2025
37 of 38 checks passed
@mjhuff mjhuff deleted the app_lpc-redesign-attach-probe branch February 26, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants