feat(protocol-designer, step-generation): add prepareToAspirate
#17590
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Here, I introduce and wire up the
prepareToAspirate
atomic command in step generation. This command is necessary for our in place commands:airGapInPlace
andaspirateInPlace
, which are curried when implementing air gap at a trash bin or waste chute addressable area.Implicated by this introduction of
prepareToAspirate
betweenmoveToAddressableArea
andairGapInPlace
are isprotocol-designer/src/steplist/substepTimeline.ts
. Previously, we gleaned information from accessing themoveToAddressableArea
command preceding the inPlace command, presuming it was the direct preceding command. Now, those commands are separated by aprepareToAspirate
command, so I introduce a utility to get the most recentmoveToAddressableArea
command relatvie to the inPlace command, and wire up insubstepTimeline.ts
Note that
prepareToAspirate
does not affect robot state.Closes RQA-3968
Test Plan and Hands on Testing
Changelog
prepareToAspirate
atomic command in step generationmoveToAddressableArea
command for inPlace commandsReview requests
see test plan
Risk assessment
medium. touches step generation commands