Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): update question-mark-circle icon #17591

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 26, 2025

Closes EXEC-1249

Overview

By popular demand, the question-mark-circle icon is now just help, and a redundant icon is deleted (per Design direction).

Test Plan and Hands on Testing

Risk assessment

low

@mjhuff mjhuff requested review from a team February 26, 2025 16:11
@mjhuff mjhuff requested a review from a team as a code owner February 26, 2025 16:11
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 24.74%. Comparing base (7fdb309) to head (339fd0c).
Report is 1 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/App/Navbar.tsx 0.00% 1 Missing ⚠️
...ecules/OT2CalibrationNeedHelpLink/NeedHelpLink.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17591      +/-   ##
==========================================
- Coverage   25.64%   24.74%   -0.91%     
==========================================
  Files        2841     2841              
  Lines      218631   218637       +6     
  Branches    17944    17945       +1     
==========================================
- Hits        56077    54093    -1984     
- Misses     162539   164530    +1991     
+ Partials       15       14       -1     
Flag Coverage Δ
app 2.49% <0.00%> (-0.94%) ⬇️
protocol-designer 18.87% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/icons/icon-data.ts 100.00% <100.00%> (ø)
app/src/App/Navbar.tsx 0.00% <0.00%> (ø)
...ecules/OT2CalibrationNeedHelpLink/NeedHelpLink.tsx 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray

@mjhuff mjhuff requested a review from mmencarelli February 26, 2025 16:18
@mjhuff mjhuff merged commit 39dc008 into edge Feb 26, 2025
66 checks passed
@mjhuff mjhuff deleted the components_update-question-mark-icon branch February 26, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants