fix(protocol-designer): Add viewport size to mixpanel #17592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add viewport width and height as a prop on mixpanel close AUTH-1495
ncdiehl11
approved these changes
Feb 26, 2025
alexjoel42
pushed a commit
that referenced
this pull request
Feb 27, 2025
* fix(protocol-designer): Add viewport size to mixpanel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add viewport size to Mixpanel
Mixpanel default properties don't support viewport that we need to check to offer better UI and UX
https://docs.mixpanel.com/docs/data-structure/property-reference/default-properties#event-properties-1
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment
low