Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer, shared-data): update command schema to v10 #17593

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Feb 26, 2025

Overview

As an oversight, PD 8.4.0 maintained exporting protocols with command schema v8. This PR updates the command schema to v10.

Test Plan and Hands on Testing

  • ensure exporting a protocol on this branch produces command schema v10

Changelog

  • update command schema to v10
  • update fixtures

Review requests

see test plan

Risk assessment

lowish

…7550)

As an oversight, PD 8.4.0 maintained exporting protocols with command
schema v8. This PR updates the command schema to v10.
@ncdiehl11 ncdiehl11 requested a review from koji February 26, 2025 17:38
@ncdiehl11 ncdiehl11 self-assigned this Feb 26, 2025
@ncdiehl11 ncdiehl11 marked this pull request as ready for review February 26, 2025 17:40
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 26, 2025 17:40
@ncdiehl11 ncdiehl11 merged commit a77eaf8 into chore_release-pd-8.4.3 Feb 26, 2025
72 of 73 checks passed
@ncdiehl11 ncdiehl11 deleted the feat_pd-command-schema branch February 26, 2025 18:24
alexjoel42 pushed a commit that referenced this pull request Feb 27, 2025
…7593)

As an oversight, PD 8.4.0 maintained exporting protocols with command
schema v8. This PR updates the command schema to v10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants