refactor(components): update Tag styling to inherit width by default #17595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some of the componentization work for the LPC Redesign introduces a new table that takes children, and
Tag
will be heavily utilized by this component in the future. In order forTag
to properly occupy the width of the container,width
should be inherited, otherwise it's impossible forTag
to ever occupy the entire container without some hacks.Test Plan and Hands on Testing
Tag
renders as expected, but I did not check every last occurence.Review requests
Tag
would break by doing this? I think we're safe, but if anyone has any ideas, I'd be happy to double-check those spots.Risk assessment
lowish - might break some styling in PD