Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): update Tag styling to inherit width by default #17595

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 26, 2025

Overview

Some of the componentization work for the LPC Redesign introduces a new table that takes children, and Tag will be heavily utilized by this component in the future. In order for Tag to properly occupy the width of the container, width should be inherited, otherwise it's impossible for Tag to ever occupy the entire container without some hacks.

Test Plan and Hands on Testing

  • Smoke tested PD to ensure that Tag renders as expected, but I did not check every last occurence.

Review requests

  • Are there any likely places Tag would break by doing this? I think we're safe, but if anyone has any ideas, I'd be happy to double-check those spots.

Risk assessment

lowish - might break some styling in PD

@mjhuff mjhuff requested review from koji, ncdiehl11, jerader and a team February 26, 2025 18:49
@mjhuff mjhuff requested a review from a team as a code owner February 26, 2025 18:49
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 25.63%. Comparing base (7fdb309) to head (c437f7b).
Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
...er/src/organisms/AssignLiquidsModal/LiquidCard.tsx 0.00% 4 Missing ⚠️
...ner/ProtocolSteps/Timeline/MultichannelSubstep.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17595      +/-   ##
==========================================
- Coverage   25.64%   25.63%   -0.01%     
==========================================
  Files        2841     2841              
  Lines      218631   218720      +89     
  Branches    17944    17944              
==========================================
+ Hits        56077    56078       +1     
- Misses     162539   162627      +88     
  Partials       15       15              
Flag Coverage Δ
protocol-designer 18.87% <28.57%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/atoms/Tag/index.tsx 86.44% <100.00%> (ø)
...esigner/src/organisms/MaterialsListModal/index.tsx 94.41% <100.00%> (+0.02%) ⬆️
...ner/ProtocolSteps/Timeline/MultichannelSubstep.tsx 2.46% <0.00%> (-0.04%) ⬇️
...er/src/organisms/AssignLiquidsModal/LiquidCard.tsx 1.12% <0.00%> (-0.02%) ⬇️

... and 4 files with indirect coverage changes

@ncdiehl11 ncdiehl11 requested a review from a team as a code owner February 26, 2025 19:55
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving on behalf of PD 👍

@mjhuff
Copy link
Contributor Author

mjhuff commented Feb 26, 2025

approving on behalf of PD 👍

Thanks for taking the time to audit. Much appreciated.

@mjhuff mjhuff merged commit c7b2aea into edge Feb 26, 2025
38 checks passed
@mjhuff mjhuff deleted the components_fix-tag-width branch February 26, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants