fix(protocol-designer) fix drag and drop flickering issue #17600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix drag and drop flickering issue close AUTH-1471
ncdiehl11
approved these changes
Feb 27, 2025
| useEffect(() => { | ||
| const timer = setTimeout(() => { | ||
| setStableOpacity(slotFillOpacity) | ||
| }, 50) |
There was a problem hiding this comment.
is this arbitrary? just the smallest number that works?
There was a problem hiding this comment.
no, but the value should be less than 100 since if we put a big number, ovelay isn't responded immediately.
i tested a couple of cases.
500: too slow and for swap labware, it didn't worked
200: a little bit slow for swap labware, kind of work but overlay's behavior is a little bit weird.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
fix drag and drop flickering issue
add debounce to set opacity since for drag & drop, controlling the render itself is kind of hard
Emily approved this update.
https://opentrons.slack.com/archives/C08CX5C6XA9/p1740665958752359?thread_ts=1740613084.868439&cid=C08CX5C6XA9
close AUTH-1471
Test Plan and Hands on Testing
create or import a protocol and go to edit protocol then try drag & drop labwares
Changelog
Review requests
Risk assessment
low