-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol-designer,shared-data): add description to liquid classes #17602
Conversation
Here, I add a required description field to liquid class schema, definitions, and TS interface. I also implement this description in DefineLiquidsModal, and ensure we are getting all current liquid class definitions in `getAllLiquidClassDefs`. Closes AUTH-1494
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17602 +/- ##
==========================================
- Coverage 25.70% 24.53% -1.17%
==========================================
Files 2843 2850 +7
Lines 218884 219335 +451
Branches 17947 18078 +131
==========================================
- Hits 56268 53823 -2445
- Misses 162601 165503 +2902
+ Partials 15 9 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema and python changes look good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm in PD!
Overview
Here, I add a required description field to liquid class schema, definitions, TS interface, and pydantic model. I also implement this description in DefineLiquidsModal, and ensure we are getting all current liquid class definitions in
getAllLiquidClassDefs
.Closes AUTH-1494
Test Plan and Hands on Testing
Changelog
DefineLiquidsModal
Review requests
see test plan
Risk assessment
low