feat(app): add DeckInfoLabelTextTag component #17605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
force-pushed
the
app_add-deckinfolabeltexttag-component
branch
3 times, most recently
from
ef7d6f9 to
af0bf55
Compare
ncdiehl11
reviewed
Feb 27, 2025
koji
reviewed
Feb 28, 2025
koji
reviewed
Feb 28, 2025
| grid-template-columns: 1fr 1fr 1fr; | ||
| } | ||
|
|
||
| @media (max-width: 450px) { |
There was a problem hiding this comment.
could you tell me why this uses 450px?
There was a problem hiding this comment.
Yes, we decided not to use the intermediate breakpoint, and Design is making the assumption that text will be 4 characters long, which in practice is never going to be the case by a long shot. Using 450px is more reasonable than 177px. I'm talking to her about this when she gets back and can put up a fix if necessary.
koji
approved these changes
Feb 28, 2025
Of course. Thanks for taking the time to review all these PRs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes EXEC-1243
Overview
Adds the
DeckInfoLabelTextTagcomponent per designs. Breakpoints here.NOTE: The Designs at the above file insinuate that the background-color is grey, but that's not actually the case.
ODD
Desktop
Test Plan and Hands on Testing
Changelog
Risk assessment
low