fix(shared-data): Keep inner well geometries of sibling labware in sync with each other #17606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
requested review from
ryanthecoder,
caila-marashaj and
a team
This copies geometry across definitions: opentrons_24_tuberack_generic_2ml_screwcap --> opentrons_24_aluminumblock_generic_2ml_screwcap. The tuberack one was already correct before this PR, but the aluminumblock one didn't have any geometry, even though it's the same tubes.
This copies geometry across definitions: opentrons_24_tuberack_nest_1.5ml_snapcap --> opentrons_24_aluminumblock_nest_1.5ml_snapcap The tuberack one was already correct before this PR, but its updates in PR #17082 were never propagated to the aluminumblock one.
This copies geometry across definitions: opentrons_24_tuberack_nest_2ml_snapcap --> opentrons_24_aluminumblock_nest_2ml_snapcap. The tuberack one was already correct before this PR, but its updates in PR #17082 were never propagated to the aluminumblock one.
This copies geometry across definitions: opentrons_10_tuberack_nest_4x50ml_6x15ml_conical --> opentrons_6_tuberack_nest_50ml_conical --> opentrons_15_tuberack_nest_15ml_conical 4x50ml_6x15ml was already correct before this PR, but its updates in #17082 were never propagated to the other two definitions.
SyntaxColoring
force-pushed
the
keep_siblings_in_sync
branch
from
3ae7bb1 to
04f64bf
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17606 +/- ##
==========================================
- Coverage 63.08% 63.07% -0.01%
==========================================
Files 2840 2843 +3
Lines 218766 219410 +644
Branches 18142 18323 +181
==========================================
+ Hits 138010 138400 +390
- Misses 80564 80818 +254
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. |
sfoster1
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fixes some out-of-date labware geometry definitions and tries to prevent similar problems in the future.
Some of our labware definitions ought to share well geometries with each other. For example,
opentrons_24_aluminumblock_nest_0.5ml_screwcapandopentrons_24_tuberack_nest_0.5ml_screwcaphave the same NEST 0.5 mL screwcap tubes.It's proving to be challenging to keep all of these in sync. The underlying spreadsheets from the hardware team don't necessarily enumerate every single definition. So, some labware seem like they were accidentally omitted from the updates in #17082, and other labware just never had any geometry definitions to begin with.
This PR fixes the discrepancies that I found. Then, to mitigate the problem going forward, this PR hard-codes list of labware that belong to the same "shared geometry groups." In the tests, we assert that each group has consistent geometry.
Test Plan and Hands on Testing
None.
Changelog
Review requests
Risk assessment
Medium. This might reconcile a group in the wrong direction.