chore(js): Disable @typescript-eslint/consistent-indexed-object-style, for real this time #17607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxColoring
requested review from
TamarZanzouri
and removed request for
a team
TamarZanzouri
approved these changes
Feb 27, 2025
|
@SyntaxColoring
I guess it might be the result of the gradual TypeScript migration and app&ui folks didn't update eslint config entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
#17557 did not quite do the trick, because in addition to the top-level
rulesconfig, we also need to updateoverrides.Sorry—I swear I tested it before merging and it seemed like it was working! 🤦
Test Plan and Hands on Testing
make lint-jsbefore and after this PR, grep forconsistent, and make sure the fix actually works this time.Review requests
My understanding of
overridesis that you can narrow them down to specific sets of files. But these overrides are written to apply to every .ts and .tsx file, so...what's the point? Anyone know why we wouldn't just define these in the top-levelrules?Risk assessment
No risk.