Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add cypress/downloads to eslintignore #17608

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

koji
Copy link
Contributor

@koji koji commented Feb 27, 2025

Overview

add cypress/downloads to eslintignore to avoid pretiier format error after running e2e

Test Plan and Hands on Testing

  1. make -C protocol-designer test-e2e
    check that there are json files in protocol-designer/cypress/downloads
  2. make lint-js
    no errors

Changelog

Review requests

Risk assessment

low

add cypress/downloads to eslintignore
@koji koji requested review from y3rsh and ncdiehl11 February 27, 2025 20:15
@koji koji marked this pull request as ready for review February 27, 2025 20:15
@koji koji requested a review from a team as a code owner February 27, 2025 20:15
@koji koji removed the request for review from a team February 27, 2025 20:19
Copy link
Collaborator

@ncdiehl11 ncdiehl11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@koji koji merged commit 097579a into chore_release-pd-8.4.3 Feb 27, 2025
10 checks passed
@koji koji deleted the chore_add-download-ignore-list branch February 27, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants