fix(ab): verify protocol test intention matches analysis output #17611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y3rsh
added
the
gen-analyses-snapshot-pr
y3rsh
changed the title
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17625 |
|
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17626 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17611 +/- ##
=======================================
Coverage 25.68% 25.68%
=======================================
Files 2850 2850
Lines 219210 219210
Branches 17955 17955
=======================================
Hits 56300 56300
Misses 162895 162895
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. |
y3rsh
commented
Mar 3, 2025
Comment on lines
+46
to
+49
| # which is best to check??? | ||
| # they both give the same result | ||
| # errors_present = data["errors"] != [] | ||
| errors_present = data["result"] != "ok" |
There was a problem hiding this comment.
What is the right test here?
There was a problem hiding this comment.
They should be equivalent.
SyntaxColoring
approved these changes
Mar 3, 2025
analyses-snapshot-testing/files/protocols/Flex_X_v2_18_NO_PIPETTES_DescriptionTooLongRTP.py
Outdated
Show resolved
Hide resolved
…TTES_DescriptionTooLongRTP.py Co-authored-by: Max Marrone <max@opentrons.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analyses Snapshot Tests
Add explicit test to validate snapshot error state.
Important
When we review changes to snapshots it is not obvious enough when a snapshot that is supposed to have errors no longer does, and vice versa.
_S_in their name or are from the protocol library should not have errors in their analysis_X_in their name are expected to have errors.Notes
Bugs