Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add HeadlineTagBtn component #17612

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 28, 2025

Closes EXEC-1247

Overview

Adds the new HeadlineTagBtn from Figma designs for app usage. Note that the container in Figma is actually not a part of the component, see here.

Screenshot 2025-02-28 at 9 29 31 AM

Test Plan and Hands on Testing

Changelog

  • Added new HeadlineTagBtn component.

Risk assessment

low

@mjhuff mjhuff requested review from koji, sfoster1, ncdiehl11, jerader and a team February 28, 2025 14:35
@mjhuff mjhuff requested a review from a team as a code owner February 28, 2025 14:35
@mjhuff mjhuff force-pushed the app_add-headlinetagbtn-component branch from a0858af to 327afbd Compare February 28, 2025 14:37
align-items: ${ALIGN_CENTER};
gap: ${SPACING.spacing24};

@media (max-width: 338px) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breakpoint comes from this file.

@mjhuff mjhuff changed the title feat(app): add DeckInfoLabelTextTag component feat(app): add HeadlineTagBtn component Feb 28, 2025
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

one thing I don't understand is ↓

Screenshot 2025-02-28 at 11 56 46 AM

when ran make -C components dev, head line tab button showed up, but s3 with this branch doesn't show the component 🤔

@mjhuff
Copy link
Contributor Author

mjhuff commented Feb 28, 2025

when ran make -C components dev, head line tab button showed up, but s3 with this branch doesn't show the component

I don't understand this entirely either. I think something in the AWS storybook instance requires that the instance be tore down and restarted completely in order for it to render correctly, probably due to some file path changes or something. I've had this happen a few times when I developed locally 🤷

Thank you for reviewing!

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 25.68%. Comparing base (50c487c) to head (d3d50ae).
Report is 3 commits behind head on edge.

Files with missing lines Patch % Lines
app/src/molecules/HeadlineTagBtn/index.tsx 0.00% 46 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17612      +/-   ##
==========================================
- Coverage   25.71%   25.68%   -0.03%     
==========================================
  Files        2843     2848       +5     
  Lines      218924   219149     +225     
  Branches    17949    17949              
==========================================
  Hits        56299    56299              
- Misses     162610   162835     +225     
  Partials       15       15              
Flag Coverage Δ
app 3.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/src/molecules/HeadlineTagBtn/index.tsx 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@mjhuff mjhuff merged commit caae20d into edge Feb 28, 2025
41 of 42 checks passed
@mjhuff mjhuff deleted the app_add-headlinetagbtn-component branch February 28, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants