-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): add HeadlineTagBtn component #17612
Conversation
a0858af
to
327afbd
Compare
align-items: ${ALIGN_CENTER}; | ||
gap: ${SPACING.spacing24}; | ||
|
||
@media (max-width: 338px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breakpoint comes from this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this entirely either. I think something in the AWS storybook instance requires that the instance be tore down and restarted completely in order for it to render correctly, probably due to some file path changes or something. I've had this happen a few times when I developed locally 🤷 Thank you for reviewing! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17612 +/- ##
==========================================
- Coverage 25.71% 25.68% -0.03%
==========================================
Files 2843 2848 +5
Lines 218924 219149 +225
Branches 17949 17949
==========================================
Hits 56299 56299
- Misses 162610 162835 +225
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Closes EXEC-1247
Overview
Adds the new
HeadlineTagBtn
from Figma designs for app usage. Note that the container in Figma is actually not a part of the component, see here.Test Plan and Hands on Testing
Changelog
Risk assessment
low