Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): add TextListTableContent component #17619

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Feb 28, 2025

Closes EXEC-1244

Overview

Adds the TextListTableContent component to components per designs.

Screenshot 2025-02-28 at 4 18 49 PM

Test Plan and Hands on Testing

Changelog

  • Added TextListTableContent component to Helix.

Risk assessment

low

@mjhuff mjhuff requested review from koji, sfoster1, ncdiehl11, jerader and a team February 28, 2025 21:21
@mjhuff mjhuff requested a review from a team as a code owner February 28, 2025 21:21
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.14%. Comparing base (79bbf74) to head (865d449).
Report is 3 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17619      +/-   ##
==========================================
+ Coverage   25.69%   27.14%   +1.44%     
==========================================
  Files        2847     2819      -28     
  Lines      219103   217103    -2000     
  Branches    17952    18203     +251     
==========================================
+ Hits        56300    58934    +2634     
+ Misses     162788   158150    -4638     
- Partials       15       19       +4     
Flag Coverage Δ
app 3.41% <0.00%> (-0.02%) ⬇️
components 4.74% <100.00%> (?)
labware-library 4.20% <0.00%> (-0.01%) ⬇️
opentrons-ai-client 3.30% <0.00%> (-0.01%) ⬇️
protocol-designer 18.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nents/src/molecules/TextListTableContent/index.tsx 100.00% <100.00%> (ø)

... and 140 files with indirect coverage changes

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mjhuff mjhuff merged commit 7d35e6f into edge Feb 28, 2025
60 checks passed
@mjhuff mjhuff deleted the app_add-textlisttablecontent-component branch February 28, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants