-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): Refactor select components for LPC Redesign #17622
refactor(components): Refactor select components for LPC Redesign #17622
Conversation
Adds onColor states for each listitemtype
ac284fb
to
d2b4460
Compare
d2b4460
to
2061cd7
Compare
@@ -11,10 +11,14 @@ export * from './ListItemChildren' | |||
|
|||
export type ListItemType = | |||
| 'error' | |||
| 'noActive' | |||
| 'default' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
thank you for doing this actually Nick and I talked about updating this.
protocol-designer uses this a lot. If you want us(auth team) to update them, let us know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! I went ahead and did the changes since they were failing lint (below commit). It appears there's one other component that still uses noActive
, which is ListButton
.
99b90ac
to
2a74fea
Compare
3f02bc9
to
3e6c15a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes & storybook look good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did a smoke test for the PD and there were no issues
thank you for updating type!
Closes EXEC-1242 and EXEC-1260
Overview
This PR updates a couple components as required for the LPC Redesign. There is a lot of noise in this PR. The first two commits are the non-lint solving ones.
RadioButton
See here. Just adds better defined subtext, supporting vertical and horizontal placements. This requires updating a couple implementations, too.
ListItem
See here. Just adds some new states and background colors. Renames
noActive
todefault
per Design, too.Test Plan and Hands on Testing
Risk assessment
low