test(protocol-designer): Cypress-Transfer-Platereader-Helper #17623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjoel42
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## chore_release-pd-8.4.3 #17623 +/- ##
=======================================================
Coverage 18.62% 18.62%
=======================================================
Files 2743 2743
Lines 211801 211812 +11
Branches 6534 6541 +7
=======================================================
+ Hits 39442 39449 +7
- Misses 172359 172363 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
koji
changed the title
|
@alexjoel42 |
y3rsh
requested changes
Mar 3, 2025
There was a problem hiding this comment.
As you are getting this working, make sure to add cy.log in functions with even a little complexity as well as parameterized functions so troubleshooting is easier.
Also, do not add any more scope to this PR. I would make small PRs that create one composite step at a time so that they may be easily reviewed.
Just noticed another issue to fix in this PR when troubleshooting the below error.
- We have 4
describewith the nameThe Redesigned Create Protocol Landing Page- rename them distincly - We have 4
itwith the same namecontent and step 1 flow works- rename them distinctly
Once my PR is merged and we have distinct names on each
describeandit, we can see which test is causing this error!
[protocol-designer-tests] The Redesigned Create Protocol Landing Page
[protocol-designer-tests] 1) content and step 1 flow works
[protocol-designer-tests]
[protocol-designer-tests]
[protocol-designer-tests] 0 passing (26s)
[protocol-designer-tests] 1 failing
[protocol-designer-tests]
[protocol-designer-tests] 1) The Redesigned Create Protocol Landing Page
[protocol-designer-tests] content and step 1 flow works:
[protocol-designer-tests] Error: The following error originated from your application code, not from Cypress.
[protocol-designer-tests]
[protocol-designer-tests] > Uncaught Error: expected to find cutoutId from addressableAreaName undefined but could not
[protocol-designer-tests]
[protocol-designer-tests] When Cypress detects uncaught errors originating from your application it will automatically fail the current test.
[protocol-designer-tests]
[protocol-designer-tests] This behavior is configurable, and you can choose to turn this off by listening to the `uncaught:exception` event.
[protocol-designer-tests]
[protocol-designer-tests] https://on.cypress.io/uncaught-exception-from-application
[protocol-designer-tests] at <unknown> (http://localhost:5178/src/utils/index.ts:118:5)
@alexjoel42 Once you understand this, you can just merge it as it targets your branch.
…Platereader-Helper
|
Leaving a comment here to explain the With the new |
…Platereader-Helper
Renaming branch to avoid PD build from failing.
Trying to rename the branch
alexjoel42
added a commit
that referenced
this pull request
Mar 7, 2025
#17677) This is coppied over from #17623 because my branch name had parentheses. # Overview 1. Add plate reader smoke test 2. Add Transfer 1:1 test 3. Add helper functions to test if we like that pattern to reduce work used in createNewFlex.cy.ts ## Test Plan and Hands on Testing ## Changelog Added test coverage for transfer. Might need to be refactored once we work on liquid classes. Will likely cause some issues until Jethary's PR is pulled in ## Review requests @y3rsh ## Risk assessment Going to likely need to look through selectors when we get to liquid class work because it will change fields. That being said, having automation that can be tweaked to liquid classes is helpful. --------- Co-authored-by: Josh McVey <josh.mcvey@opentrons.com> Co-authored-by: Jethary <jethary@opentrons.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Test Plan and Hands on Testing
Changelog
Changed some of the selectors to work with PD 8.4.3
Review requests
@y3rsh
Risk assessment
Going to likely need to look through selectors when we get to liquid class work because it will change fields. That being said, having automation that can be tweaked to liquid classes is helpful.