Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): Add LPC redesigned "remove probe" view on the ODD #17627

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 3, 2025

Closes EXEC-1129

Overview

Adds the ODD "remove probe" view for the LPC Redesign. Mirrors the "attach probe" view, largely.

A very small fix for probe attachment is included to unblock the view: "clicking attach probe" was proceeding two steps instead of one step.

Screen.Recording.2025-03-03.at.8.41.37.AM.mov

Test Plan and Hands on Testing

  • See video. Also covered by added testing.

Changelog

  • Added updated "remove probe" ODD screen for LPC Redesign.

Risk assessment

none, behind ff

@mjhuff mjhuff requested review from sfoster1, SyntaxColoring and a team March 3, 2025 13:53
@mjhuff mjhuff requested a review from a team as a code owner March 3, 2025 13:53
@mjhuff mjhuff requested review from jerader and removed request for a team and jerader March 3, 2025 13:53
@mjhuff mjhuff force-pushed the app_add-lpc-redesign-remove-probe-odd branch from acb65f2 to 2de1824 Compare March 3, 2025 14:22
@mjhuff mjhuff requested a review from a team as a code owner March 3, 2025 17:25
@mjhuff mjhuff force-pushed the app_add-lpc-redesign-remove-probe-odd branch from d3d393d to 2de1824 Compare March 3, 2025 17:28
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@mjhuff mjhuff merged commit 1112770 into edge Mar 7, 2025
47 checks passed
@mjhuff mjhuff deleted the app_add-lpc-redesign-remove-probe-odd branch March 7, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants