feat(protocol-designer): add off-deck variable for python #17629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17629 +/- ##
=======================================
Coverage 25.68% 25.68%
=======================================
Files 2850 2850
Lines 219210 219267 +57
Branches 17955 17960 +5
=======================================
+ Hits 56300 56316 +16
- Misses 162895 162936 +41
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ddcc4
reviewed
Mar 3, 2025
| @@ -8,6 +8,9 @@ import type { WellLocation } from '@opentrons/shared-data/command/types/support' | |||
| */ | |||
| export const PROTOCOL_CONTEXT_NAME = 'protocol' | |||
|
|
|||
| /** The variable name for defining a labware that is off-deck or being moved to off-deck */ | |||
| export const OFF_DECK = 'OFF_DECK' | |||
There was a problem hiding this comment.
Hm, does this work? You might have to say protocol_api.OFF_DECK.
There was a problem hiding this comment.
oh haha you're right. will fix
ddcc4
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
when calling
offDecklocation, it should use this varibleOFF_DECK. This will be used inmove_labwarein addition toload_labwaresee reference in the api doc here: https://docs.opentrons.com/v2/new_protocol_api.html?highlight=use_gripper#opentrons.protocol_api.OFF_DECK
Test Plan and Hands on Testing
Review the code, smoke test uploading a labware loaded off-deck to the app
Changelog
OFF_DECKvariable and plug inRisk assessment
low, behind ff