Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(abr-testing): update stacker protocols for new api #17630

Open
wants to merge 3 commits into
base: edge
Choose a base branch
from

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Mar 3, 2025

Updates the two ABR stacker protocols for the new api by

  • Switching all the load labwares to set_stored_labware
  • remove all the static mode stuff
  • That's actually pretty much it since they don't store or refill the stackers

testing

  • run em

@sfoster1 sfoster1 requested a review from rclarke0 March 3, 2025 16:37
@sfoster1 sfoster1 requested a review from a team as a code owner March 3, 2025 16:38
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.47%. Comparing base (b428d0a) to head (e869505).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #17630   +/-   ##
=======================================
  Coverage   62.47%   62.47%           
=======================================
  Files        2792     2792           
  Lines      215277   215277           
  Branches    18414    18414           
=======================================
+ Hits       134498   134499    +1     
+ Misses      80594    80593    -1     
  Partials      185      185           
Flag Coverage Δ
protocol-designer 18.94% <ø> (+<0.01%) ⬆️
step-generation 4.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@sfoster1 sfoster1 force-pushed the stacker-api-and-app branch from 3cffa38 to 2e5001c Compare March 3, 2025 22:00
@sfoster1 sfoster1 requested review from a team as code owners March 3, 2025 22:00
@sfoster1 sfoster1 requested review from mjhuff and removed request for a team March 3, 2025 22:00
Copy link
Contributor

@mjhuff mjhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App changes look good. Thanks for cleaning up getLabwareDefinitionsFromCommands.

@sfoster1 sfoster1 force-pushed the stacker-api-and-app branch from d55ad3a to e8ac4e9 Compare March 3, 2025 22:28
@sfoster1 sfoster1 force-pushed the exec-1226-protocols branch from e4940e5 to 9fd8f4d Compare March 3, 2025 22:29
Base automatically changed from stacker-api-and-app to edge March 6, 2025 14:18
@sfoster1 sfoster1 force-pushed the exec-1226-protocols branch from 9fd8f4d to 9d747e0 Compare March 6, 2025 14:20
@sfoster1 sfoster1 force-pushed the exec-1226-protocols branch from 9d747e0 to e869505 Compare March 11, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants