fix(cypress): keep composite actions as step thunks #17633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Test(PD)-Cypress-Transfer-Platereader-Helper #17633 +/- ##
=============================================================================
Coverage 18.63% 18.63%
=============================================================================
Files 2743 2743
Lines 211625 211625
Branches 6534 6534
=============================================================================
Hits 39439 39439
Misses 172186 172186
Flags with carried forward coverage won't be shown. Click here to find out more. |
y3rsh
commented
Mar 3, 2025
y3rsh
commented
Mar 3, 2025
Comment on lines
+43
to
+46
| CompositeSetupSteps.AddLabwareToDeckSlot( | ||
| 'C3', | ||
| 'Armadillo 96 Well Plate 200 µL' | ||
| ) |
There was a problem hiding this comment.
Note that this parameter intake is the strings you want.
The object is usually best but I wanted to show both.
alexjoel42
approved these changes
Mar 3, 2025
alexjoel42
merged commit 0c9e98f
into
Test(PD)-Cypress-Transfer-Platereader-Helper
14 of 16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexjoel42 Once you understand this, you can just merge it as it targets your branch.