Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-client, react-api-client): Add /labwareOffsets bindings #17634

Merged
merged 6 commits into from
Mar 3, 2025

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Mar 3, 2025

Closes EXEC-1096

Overview

Adds bindings for the /labwareOffsets resources. The bindings for the older labware offset resources located at /runs/:runId/labware_offsets are renamed to "legacy". They will still be used in the OT-2 LPC flows. The location sequence component types in api-client are hoisted out of the runs types, since these are now utilized by labware_offsets, too.

Test Plan and Hands on Testing

  • Verified these work as expected on a future branch, but these remain unimplemented for now.

Changelog

  • Added bindings for /labwareOffsets resources.

Risk assessment

low - nothing (as of yet) uses these bindings

@mjhuff mjhuff requested review from sfoster1, SyntaxColoring and a team March 3, 2025 17:34
@mjhuff mjhuff requested review from a team as code owners March 3, 2025 17:34
@mjhuff mjhuff requested review from ncdiehl11 and removed request for a team and ncdiehl11 March 3, 2025 17:34
@mjhuff mjhuff changed the title Add labware offsets bindings feat(api-client, react-api-client): Add /labwareOffsets bindings Mar 3, 2025
Copy link
Contributor

@SyntaxColoring SyntaxColoring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM functionally. Only trivial naming nitpicks. Thank you!

@mjhuff mjhuff merged commit 2ec0915 into edge Mar 3, 2025
51 checks passed
@mjhuff mjhuff deleted the add-labware-offsets-bindings branch March 3, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants