-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(app): add stacker/retrieve command handling and fix lpc crash #17638
Conversation
slightly nicer
This will prevent the whitescreen from the labware-harvesting code not knowing about new commands that link labware URIs and IDs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## edge #17638 +/- ##
==========================================
- Coverage 25.69% 25.69% -0.01%
==========================================
Files 2850 2850
Lines 219313 219383 +70
Branches 17970 17970
==========================================
+ Hits 56362 56363 +1
- Misses 162936 163005 +69
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
const isLoadCommand = ( | ||
command: RunTimeCommand | ||
): command is LoadLabwareRunTimeCommand | LoadLidRunTimeCommand => | ||
['loadLabware', 'loadLid'].includes(command.commandType) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we probably want to add loadLidStack
here too but I can handle that in my PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me & fixes the white screen I was seeing for lid protocols in LPC!
Add the app-side changes from #17620 that handle
Review requests
testing