Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(app): add stacker/retrieve command handling and fix lpc crash #17638

Merged
merged 5 commits into from
Mar 3, 2025

Conversation

sfoster1
Copy link
Member

@sfoster1 sfoster1 commented Mar 3, 2025

Add the app-side changes from #17620 that handle

  • Adding the retrieve command to some of the command parse utilities (but almost certainly not all of them)
  • Fixing an LPC whitescreen when there are any unknown definitions, which really makes the problems with forgetting the locations of some of the command parsing stuff much worse
  • Adding retrieve types

Review requests

  • cohesive enough when separated from the other pr?

testing

  • we should no longer crash when looking at a protocol that loads labware in a way we don't know about. instead that labware just isn't shown.

@sfoster1 sfoster1 requested a review from smb2268 March 3, 2025 22:06
@sfoster1 sfoster1 requested review from a team as code owners March 3, 2025 22:06
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 1.21951% with 81 lines in your changes missing coverage. Please review.

Project coverage is 25.69%. Comparing base (4952cb5) to head (b53eca1).
Report is 2 commits behind head on edge.

Files with missing lines Patch % Lines
...tString/utils/getLabwareDefinitionsFromCommands.ts 2.50% 39 Missing ⚠️
...yHistoricOffsets/hooks/getLabwareLocationCombos.ts 0.00% 30 Missing ⚠️
...s/hooks/useLPCLabwareInfo/getLPCLabwareInfoFrom.ts 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #17638      +/-   ##
==========================================
- Coverage   25.69%   25.69%   -0.01%     
==========================================
  Files        2850     2850              
  Lines      219313   219383      +70     
  Branches    17970    17970              
==========================================
+ Hits        56362    56363       +1     
- Misses     162936   163005      +69     
  Partials       15       15              
Flag Coverage Δ
protocol-designer 18.95% <1.21%> (-0.01%) ⬇️
step-generation 4.38% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/hooks/useLPCLabwareInfo/getLPCLabwareInfoFrom.ts 0.00% <0.00%> (ø)
...yHistoricOffsets/hooks/getLabwareLocationCombos.ts 0.00% <0.00%> (ø)
...tString/utils/getLabwareDefinitionsFromCommands.ts 6.52% <2.50%> (-4.59%) ⬇️

const isLoadCommand = (
command: RunTimeCommand
): command is LoadLabwareRunTimeCommand | LoadLidRunTimeCommand =>
['loadLabware', 'loadLid'].includes(command.commandType)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably want to add loadLidStack here too but I can handle that in my PR

Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me & fixes the white screen I was seeing for lid protocols in LPC!

@sfoster1 sfoster1 merged commit 8a9bb57 into edge Mar 3, 2025
60 of 63 checks passed
@sfoster1 sfoster1 deleted the stacker-app branch March 3, 2025 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants