fix(shared-data): Remove cornerOffsetFromSlot from opentrons_flex_tiprack_lid #17639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #17639 +/- ##
===========================================
+ Coverage 25.69% 63.11% +37.42%
===========================================
Files 2850 2851 +1
Lines 219383 219646 +263
Branches 17970 18243 +273
===========================================
+ Hits 56363 138637 +82274
+ Misses 163005 80817 -82188
- Partials 15 192 +177
Flags with carried forward coverage won't be shown. Click here to find out more. |
SyntaxColoring
added
the
gen-analyses-snapshot-pr
sfoster1
approved these changes
Mar 4, 2025
|
Test failures appear unrelated to this PR. |
SyntaxColoring
deleted the
opentrons_flex_tiprack_lid_corneroffsetfromslot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The labware definition for
opentrons_flex_tiprack_lidcurrently has an offset that puts it 0.71 mm "underground."From discussion with @CaseyBatten, we think this was copied from
opentrons_tough_pcr_auto_sealing_lid. It doesn't make sense here in this definition. (And it's questionable whether it makes sense for the other one in the first place, but that'd be a different PR.)Test Plan and Hands on Testing
None.
Changelog
Restore this definition's
cornerOffsetFromSlotto the default, (0, 0, 0).Review requests
Does this sound correct?
Risk assessment
We think low. This labware definition is unreleased so far, and these lids aren't normally placed directly into deck slots, anyway.