Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol-designer): fix slot details width and OT-2 deck view size #17640

Draft
wants to merge 1 commit into
base: chore_release-pd-8.4.3
Choose a base branch
from

Conversation

koji
Copy link
Contributor

@koji koji commented Mar 4, 2025

Overview

fix slot details width and OT-2 deck view size

close AUTH-1505

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

fix slot details width and ot-2 deck view size

close AUTH-1505
@koji koji changed the base branch from edge to chore_release-pd-8.4.3 March 4, 2025 00:08
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 84.12698% with 10 lines in your changes missing coverage. Please review.

Project coverage is 18.64%. Comparing base (edbf200) to head (eac0ec7).

Files with missing lines Patch % Lines
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 61.53% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-pd-8.4.3   #17640   +/-   ##
=======================================================
  Coverage                   18.63%   18.64%           
=======================================================
  Files                        2743     2744    +1     
  Lines                      211625   211635   +10     
  Branches                     6533     6533           
=======================================================
+ Hits                        39439    39452   +13     
+ Misses                     172186   172183    -3     
Flag Coverage Δ
protocol-designer 18.64% <84.12%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/Designer/DeckSetup/HoverSlotDetailsContainer.tsx 100.00% <100.00%> (ø)
...rc/pages/Designer/DeckSetup/DeckSetupContainer.tsx 72.81% <61.53%> (-1.34%) ⬇️

@koji koji added the authorship label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant